feat(configurator): mirror new feature flags onto ConfigEntsoe (parity)#350
Merged
Merged
Conversation
ConfigEntsoe is an independent dataclass (not a ConfigMulti subclass), so the
opt-in feature flags added to ConfigMulti in 19.2.0/19.3.0 were unreachable for
the ENTSO-E single-target pipeline (the one the team_4 lecture uses). Mirror
them so ConfigEntsoe(...) can enable them:
- use_population_weighted_weather, include_degree_hours,
include_apparent_temperature, degree_hours_base_{heating,cooling} (19.2.0)
- include_ephemeris_features, include_day_type_features (19.3.0)
All default off → byte-identical baseline. base.py already reads them via
getattr, so no wiring change is needed. Adds a parity test that fails if a
future ConfigMulti feature flag is not mirrored here.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
ConfigEntsoeis an independent dataclass (not aConfigMultisubclass). The opt-in feature flags added toConfigMultiin 19.2.0 (population-weighted weather, degree-hours, apparent temperature) and 19.3.0 (ephemeris, day-type) were therefore unreachable for the ENTSO-E single-target pipeline — which is exactly the path theteam_4lecture submission uses. Without this, none of the new features can be switched on there.What
Mirror onto
ConfigEntsoe(all default off → byte-identical baseline):use_population_weighted_weather,include_degree_hours,include_apparent_temperature,degree_hours_base_heating,degree_hours_base_coolinginclude_ephemeris_features,include_day_type_featuresBaseTask.build_exogenous_featuresalready reads these viagetattr, so no wiring change is needed. Addstest_config_entsoe_feature_parity.pywhich fails if a future ConfigMulti feature flag is not mirrored here.QC
Parity tests (5) pass; existing ConfigEntsoe tests (94) green. ruff/black/isort clean, REUSE compliant, docs reference regenerated.
🤖 Generated with Claude Code