Skip to content

envtest: assert orphaned + spec.networking-absent never deletes adopted objects (replicas>1) #416

Description

@bdchatham

Problem

The orphan-and-adopt preserve gate (networkingOrphaned → skip reconcileNetworking, preserve ExternalAddress, ownership-checked deletes) is covered by TestNetworking_Orphaned_PreservesExternalAddressAfterNetworkingRemoved for the single-replica case, but there is no envtest exercising the replicas>1 combination (orphaned + spec.networking removed across multiple child SeiNodes).

Impact

The per-child preserve gate is group-scoped and reasoned to apply uniformly across replicas (verified live on node-wave-0 replicas=3 and the validator batches), but a replicas>1 envtest would close the proof rather than reason it — hardening the invariant the whole orphan-and-adopt flow rests on.

Proposed approach

Add an envtest at replicas=3: orphan annotation set + spec.networking removed in one edit; assert all child SeiNodes retain ExternalAddress and no adopted Service/HTTPRoute is deleted.

Relevant experts

kubernetes-specialist

Note

The SeiNodeDeployment → SeiNetwork refactor will reshape this controller; coordinate the test's home with that design.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions