From 7e734e1f8164eca6dcb926136dd2d3c10abc8801 Mon Sep 17 00:00:00 2001 From: Henry Schreiner Date: Fri, 3 Apr 2026 09:17:30 -0500 Subject: [PATCH] fix: pc check skipped incorrectly Signed-off-by: Henry Schreiner --- src/sp_repo_review/checks/precommit.py | 6 +++--- tests/test_precommit.py | 8 ++++---- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/sp_repo_review/checks/precommit.py b/src/sp_repo_review/checks/precommit.py index 9fa988e0..39058c2b 100644 --- a/src/sp_repo_review/checks/precommit.py +++ b/src/sp_repo_review/checks/precommit.py @@ -218,7 +218,7 @@ def check(precommit: dict[str, Any], dependabot: dict[str, Any]) -> bool | None: ``` """ if any( - ecosystem.get("package-ecosystem", "") == "github-actions" + ecosystem.get("package-ecosystem", "") == "pre-commit" for ecosystem in dependabot.get("updates", []) ): return None @@ -240,7 +240,7 @@ def check(precommit: dict[str, Any], dependabot: dict[str, Any]) -> bool | None: ``` """ if any( - ecosystem.get("package-ecosystem", "") == "github-actions" + ecosystem.get("package-ecosystem", "") == "pre-commit" for ecosystem in dependabot.get("updates", []) ): return None @@ -262,7 +262,7 @@ def check(precommit: dict[str, Any], dependabot: dict[str, Any]) -> bool | None: ``` """ if any( - ecosystem.get("package-ecosystem", "") == "github-actions" + ecosystem.get("package-ecosystem", "") == "pre-commit" for ecosystem in dependabot.get("updates", []) ): return None diff --git a/tests/test_precommit.py b/tests/test_precommit.py index e589c3da..2b2e8236 100644 --- a/tests/test_precommit.py +++ b/tests/test_precommit.py @@ -290,7 +290,7 @@ def test_pc901(): def test_pc901_not_needed(): dependabot = yaml.safe_load(""" updates: - - package-ecosystem: "github-actions" + - package-ecosystem: "pre-commit" """) assert compute_check("PC901", precommit={}, dependabot=dependabot).result is None @@ -324,7 +324,7 @@ def test_pc902_no_msg(): def test_pc902_not_needed(): dependabot = yaml.safe_load(""" updates: - - package-ecosystem: "github-actions" + - package-ecosystem: "pre-commit" """) assert compute_check("PC902", precommit={}, dependabot=dependabot).result is None @@ -350,13 +350,13 @@ def test_pc903_no_msg(): def test_pc903_not_needed(): dependabot = yaml.safe_load(""" updates: - - package-ecosystem: "github-actions" + - package-ecosystem: "pre-commit" """) assert compute_check("PC903", precommit={}, dependabot=dependabot).result is None def test_repo_review_checks_skips_with_lefthook_only(tmp_path: Path) -> None: - """PreCommit checks should be omitted if only lefthook.yml is present. + """Precommit checks should be omitted if only lefthook.yml is present. When a repository uses `lefthook.yml` and does not have a `.pre-commit-config.yaml`, `repo_review_checks` should return an empty