From 3c503f0a4ec1ad9ad38542673140c09935c889d5 Mon Sep 17 00:00:00 2001 From: saagpatel Date: Wed, 10 Jun 2026 03:24:52 -0700 Subject: [PATCH 1/2] docs: refresh Codex context contract --- .github/pull_request_template.md | 12 ++++++------ AGENTS.md | 27 +++++++++------------------ 2 files changed, 15 insertions(+), 24 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index d0e74e6..e32f25f 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,12 +1,12 @@ ## What -- +- ## Why -- +- ## How -- +- ## Testing - Commands run: @@ -20,13 +20,13 @@ - DB query delta: ## Risk / Notes -- +- ## Screenshots (UI only) -- +- ## Lockfile rationale (if lockfile changed) -- +- ## Baseline governance (if .perf-baselines changed) - `perf-baseline-update` label applied: diff --git a/AGENTS.md b/AGENTS.md index 323babe..95b8547 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -1,23 +1,14 @@ -## Definition of Done: Tests + Docs (Blocking) +# AGENTS.md -## Communication Contract (Global) +## Communication Contract -- Follow `/Users/d/.codex/policies/communication/BigPictureReportingV1.md` for all user-facing updates. -- Use exact section labels from `BigPictureReportingV1.md` for default status/progress updates. -- Keep default updates beginner-friendly, big-picture, and low-noise. -- Keep technical details in internal artifacts unless explicitly requested by the user. -- Honor toggles literally: `simple mode`, `show receipts`, `tech mode`, `debug mode`. +- Inherit global Codex communication and reporting rules from `/Users/d/.codex/AGENTS.override.md` and `/Users/d/.codex/policies/communication/BigPictureReportingV1.md`. +- Repo-specific instructions below add project constraints only; do not restate global voice or status-reporting rules here. -- Any production code change must include meaningful test updates in the same PR. -- Meaningful tests must include at least: - - one primary behavior assertion - - two non-happy-path assertions (edge, boundary, invalid input, or failure mode) -- Trivial assertions are forbidden (`expect(true).toBe(true)`, snapshot-only without semantic assertions, render-only smoke tests without behavior checks). -- Mock only external boundaries (network, clock, randomness, third-party SDKs). Do not mock the unit under test. -- UI changes must cover state matrix: loading, empty, error, success, disabled, focus-visible. -- API/command surface changes must update generated contract artifacts and request/response examples. -- Architecture-impacting changes must include an ADR in `/docs/adr/`. -- Required checks are blocking when `fail` or `not-run`: lint, typecheck, tests, coverage, diff coverage, docs check. -- Reviewer -> fixer -> reviewer loop is required before merge. + +## Inherited Operating Rules + +- Inherit global git, review/fix, testing, docs, UI, skill-use, and reporting gates from `/Users/d/.codex/AGENTS.md` and active session instructions. +- Add repo-specific constraints here only when this project has instructions that differ from global Codex defaults. From bd815374e63ebde410ac69b164888c092548adeb Mon Sep 17 00:00:00 2001 From: saagpatel Date: Wed, 10 Jun 2026 03:28:46 -0700 Subject: [PATCH 2/2] docs: sync uppercase pull request template --- .github/PULL_REQUEST_TEMPLATE.md | 35 ++++++++++++++++++++++++-------- 1 file changed, 26 insertions(+), 9 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index df5e921..e32f25f 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,17 +1,34 @@ + ## What - -Brief description of the changes. +- ## Why - -Why is this change needed? +- ## How +- + +## Testing +- Commands run: +- Results: + +## Performance impact +- Bundle delta: +- Build time delta: +- Lighthouse delta: +- API latency delta: +- DB query delta: + +## Risk / Notes +- -How were the changes implemented? Any design decisions worth noting? +## Screenshots (UI only) +- -## Checklist +## Lockfile rationale (if lockfile changed) +- -- [ ] Tests pass -- [ ] No new warnings -- [ ] Documentation updated (if applicable) +## Baseline governance (if .perf-baselines changed) +- `perf-baseline-update` label applied: +- Reviewer signoff: +- Rollback note: