From 221954c65f602b97ab2addb12f31aa072361628b Mon Sep 17 00:00:00 2001 From: Lei Huang Date: Mon, 15 Jun 2026 10:56:46 -0400 Subject: [PATCH 1/3] Add intrinsics support on Linux on Power for vec_add(vector_double, vector_double). --- crates/core_arch/src/powerpc/vsx.rs | 46 +++++++++++++++++++++++++++++ 1 file changed, 46 insertions(+) diff --git a/crates/core_arch/src/powerpc/vsx.rs b/crates/core_arch/src/powerpc/vsx.rs index 60cb2ad44c..159f57395c 100644 --- a/crates/core_arch/src/powerpc/vsx.rs +++ b/crates/core_arch/src/powerpc/vsx.rs @@ -10,6 +10,7 @@ use crate::core_arch::powerpc::*; use crate::core_arch::simd::*; +use crate::intrinsics::simd::simd_add; #[cfg(test)] use stdarch_test::assert_instr; @@ -70,6 +71,12 @@ mod sealed { unsafe fn vec_xxpermdi(self, b: Self, dm: u8) -> Self; } + #[unstable(feature = "stdarch_powerpc", issue = "111145")] + pub trait VectorAdd { + type Result; + unsafe fn vec_add(self, other: Other) -> Self::Result; + } + // xxpermdi has an big-endian bias and extended mnemonics #[inline] #[target_feature(enable = "vsx")] @@ -171,6 +178,34 @@ mod sealed { vec_mergeeo! { vector_unsigned_int, mergee, mergeo } vec_mergeeo! { vector_bool_int, mergee, mergeo } vec_mergeeo! { vector_float, mergee, mergeo } + + #[inline] + #[target_feature(enable = "vsx")] + #[cfg_attr(test, assert_instr(xvadddp))] + unsafe fn vec_add_double_double(a: vector_double, b: vector_double) -> vector_double { + simd_add(a, b) + } + + #[unstable(feature = "stdarch_powerpc", issue = "111145")] + impl sealed::VectorAdd for vector_double { + type Result = vector_double; + #[inline] + #[target_feature(enable = "vsx")] + unsafe fn vec_add(self, other: vector_double) -> Self::Result { + vec_add_double_double(self, other) + } + } +} + +/// Vector add for double-precision floating-point vectors. +#[inline] +#[target_feature(enable = "vsx")] +#[unstable(feature = "stdarch_powerpc", issue = "111145")] +pub unsafe fn vec_add(a: T, b: U) -> >::Result +where + T: sealed::VectorAdd, +{ + a.vec_add(b) } /// Vector permute. @@ -255,4 +290,15 @@ mod tests { test_vec_xxpermdi! {test_vec_xxpermdi_i64x2, i64x2, vector_signed_long, [0], [-1], [2], [-3]} test_vec_xxpermdi! {test_vec_xxpermdi_m64x2, m64x2, vector_bool_long, [false], [true], [false], [true]} test_vec_xxpermdi! {test_vec_xxpermdi_f64x2, f64x2, vector_double, [0.0], [1.0], [2.0], [3.0]} + + #[simd_test(enable = "vsx")] + fn test_vec_add_f64x2_f64x2() { + let a = vector_double::from(f64x2::from_array([1.0, 2.0])); + let b = vector_double::from(f64x2::from_array([3.0, 4.0])); + let expected = vector_double::from(f64x2::from_array([4.0, 6.0])); + + unsafe { + assert_eq!(f64x2::from(vec_add(a, b)), f64x2::from(expected)); + } + } } From 581f3589d3bca1e3ea2d608032a940fa0433382c Mon Sep 17 00:00:00 2001 From: Lei Huang Date: Mon, 15 Jun 2026 12:50:35 -0400 Subject: [PATCH 2/3] fix ambiguous export issue with vec_add --- crates/core_arch/src/powerpc/altivec.rs | 2 +- crates/core_arch/src/powerpc/vsx.rs | 34 +++++++------------------ 2 files changed, 10 insertions(+), 26 deletions(-) diff --git a/crates/core_arch/src/powerpc/altivec.rs b/crates/core_arch/src/powerpc/altivec.rs index ccfed88a93..9e8af48fa6 100644 --- a/crates/core_arch/src/powerpc/altivec.rs +++ b/crates/core_arch/src/powerpc/altivec.rs @@ -411,7 +411,7 @@ unsafe extern "unadjusted" { } #[macro_use] -mod sealed { +pub(crate) mod sealed { use super::*; #[unstable(feature = "stdarch_powerpc", issue = "111145")] diff --git a/crates/core_arch/src/powerpc/vsx.rs b/crates/core_arch/src/powerpc/vsx.rs index 159f57395c..f0da3d478c 100644 --- a/crates/core_arch/src/powerpc/vsx.rs +++ b/crates/core_arch/src/powerpc/vsx.rs @@ -71,12 +71,6 @@ mod sealed { unsafe fn vec_xxpermdi(self, b: Self, dm: u8) -> Self; } - #[unstable(feature = "stdarch_powerpc", issue = "111145")] - pub trait VectorAdd { - type Result; - unsafe fn vec_add(self, other: Other) -> Self::Result; - } - // xxpermdi has an big-endian bias and extended mnemonics #[inline] #[target_feature(enable = "vsx")] @@ -182,30 +176,20 @@ mod sealed { #[inline] #[target_feature(enable = "vsx")] #[cfg_attr(test, assert_instr(xvadddp))] - unsafe fn vec_add_double_double(a: vector_double, b: vector_double) -> vector_double { + pub(crate) unsafe fn vec_add_double_double(a: vector_double, b: vector_double) -> vector_double { simd_add(a, b) } - - #[unstable(feature = "stdarch_powerpc", issue = "111145")] - impl sealed::VectorAdd for vector_double { - type Result = vector_double; - #[inline] - #[target_feature(enable = "vsx")] - unsafe fn vec_add(self, other: vector_double) -> Self::Result { - vec_add_double_double(self, other) - } - } } -/// Vector add for double-precision floating-point vectors. -#[inline] -#[target_feature(enable = "vsx")] +// Implement AltiVec's VectorAdd trait for vector_double to enable vec_add support #[unstable(feature = "stdarch_powerpc", issue = "111145")] -pub unsafe fn vec_add(a: T, b: U) -> >::Result -where - T: sealed::VectorAdd, -{ - a.vec_add(b) +impl crate::core_arch::powerpc::altivec::sealed::VectorAdd for vector_double { + type Result = vector_double; + #[inline] + #[target_feature(enable = "vsx")] + unsafe fn vec_add(self, other: vector_double) -> Self::Result { + sealed::vec_add_double_double(self, other) + } } /// Vector permute. From e67122b3e7e261aec84e56981e2afc2d2dabf767 Mon Sep 17 00:00:00 2001 From: Lei Huang Date: Mon, 15 Jun 2026 15:25:05 -0400 Subject: [PATCH 3/3] fmt --- crates/core_arch/src/powerpc/vsx.rs | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/crates/core_arch/src/powerpc/vsx.rs b/crates/core_arch/src/powerpc/vsx.rs index f0da3d478c..7b648cbb7b 100644 --- a/crates/core_arch/src/powerpc/vsx.rs +++ b/crates/core_arch/src/powerpc/vsx.rs @@ -176,7 +176,10 @@ mod sealed { #[inline] #[target_feature(enable = "vsx")] #[cfg_attr(test, assert_instr(xvadddp))] - pub(crate) unsafe fn vec_add_double_double(a: vector_double, b: vector_double) -> vector_double { + pub(crate) unsafe fn vec_add_double_double( + a: vector_double, + b: vector_double, + ) -> vector_double { simd_add(a, b) } }