From ccaf7197e1ce606927d7f129606c8b8848d4475b Mon Sep 17 00:00:00 2001 From: Guillaume Gomez Date: Tue, 30 Jun 2026 18:48:36 +0200 Subject: [PATCH] Add comment explaining why we don't handle all function parameter attributes in GCC --- src/abi.rs | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/abi.rs b/src/abi.rs index 1b7bb8c9077..00e43dab0f8 100644 --- a/src/abi.rs +++ b/src/abi.rs @@ -146,6 +146,14 @@ impl<'gcc, 'tcx> FnAbiGccExt<'gcc, 'tcx> for FnAbi<'tcx, Ty<'tcx>> { if attrs.regular.contains(rustc_target::callconv::ArgAttribute::NonNull) { non_null_args.push(arg_index as i32 + 1); } + // There are a few others `ArgAttribute` variants" + // + // * ArgAttribute::ReadOnly: `access(read_only())`, but it's only used for emitting + // warning, not for optimization. + // * ArgAttribute::NoUndef: No equivalent in GCC + // * ArgAttribute::Writable: `access(read_write())` or `access(write_only())`, but it's + // only used for emitting warning, not for optimization. + // * ArgAttribute::NoFree: No equivalent in GCC ty }; #[cfg(not(feature = "master"))]