Skip to content

chore: remove finalhandler workaround for http2 #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chenjiahan merged 1 commit into from
Jun 3, 2026
Merged

chore: remove finalhandler workaround for http2 #228

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 0 additions & 20 deletions src/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1568,26 +1568,6 @@ class Server<
},
});

const isHTTP2 =
(this.options.server as ServerConfiguration<A, S>).type === 'http2';

if (isHTTP2) {
// TODO patch for https://github.com/pillarjs/finalhandler/pull/45, need remove then will be resolved
middlewares.push({
name: 'http2-status-message-patch',
middleware: (_req: Request, res: Response, next: NextFunction) => {
Object.defineProperty(res, 'statusMessage', {
get() {
return '';
},
set() {},
});

next();
},
});
}

// compress is placed last and uses unshift so that it will be the first middleware used
if (this.options.compress) {
middlewares.push({
Expand Down
Loading