Speedups#291
Open
TeunHuijben wants to merge 3 commits into
Open
Conversation
…is saves a double fetch of the attributes from the root.
…yView, for example)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #291 +/- ##
=======================================
Coverage 87.73% 87.73%
=======================================
Files 57 57
Lines 4890 4892 +2
Branches 862 862
=======================================
+ Hits 4290 4292 +2
Misses 378 378
Partials 222 222 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JoOkuma
reviewed
Jun 1, 2026
JoOkuma
left a comment
JoOkuma
left a comment
Member
There was a problem hiding this comment.
Hi @TeunHuijben, thanks for the PR, very minor comment, everything else looks Ok.
| for i, node_id in enumerate(node_ids): | ||
| new_attrs = dict(old_attrs_by_id[node_id]) | ||
| for k, v in attrs.items(): | ||
| if k in new_attrs: |
Member
There was a problem hiding this comment.
Hi, is if k in new_attrs necessary?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two perf fixes in GraphView, both on hot paths used by interactive editing
(BBoxSpatialFilter, GraphArrayView).
remove_node: replaced O(E²) bookkeeping cleanup with an O(degree) capture
of incident edges before the node is removed. Measured on a 2000-node /
density-5 view, 50 deletions: 52s → 2ms (~22000×).
update_node_attrs: when a listener is attached, the signal payload used to
require two queries to root (old attrs + new attrs). The new attrs are now
derived by overlaying the applied
attrsonto old_attrs, saving onequery. ~3-6× on small interactive batches with SQL backend; neutral
otherwise.
Adds a benchmark for the listener-attached update_node_attrs path so the
gain is visible in ASV comparisons going forward.