[rfile] ListKeys: don't include the root directory itself in the listing#22542
Open
silverweed wants to merge 1 commit into
Open
[rfile] ListKeys: don't include the root directory itself in the listing#22542silverweed wants to merge 1 commit into
silverweed wants to merge 1 commit into
Conversation
Test Results 21 files 21 suites 3d 10h 18m 53s ⏱️ For more details on these failures, see this check. Results for commit ef1c2d7. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
changes the behavior of
RFile::ListKeysto exclude the root directory itself from the list of returned keyInfos.Previously
ListKeys("a", kListDirs)would return (e.g.){ "a", "a/b", "a/c", "a/d" }; now it only returns{ "a/b", "a/c", "a/d" }.Rationale: you generally don't care about the root dir in the listing, since you already know it's there.