Skip to content

[RF] Fix Windows compiler warnings about mixing int and bool#22540

Merged
guitargeek merged 1 commit into
root-project:masterfrom
guitargeek:windows_warnings
Jun 9, 2026
Merged

[RF] Fix Windows compiler warnings about mixing int and bool#22540
guitargeek merged 1 commit into
root-project:masterfrom
guitargeek:windows_warnings

Conversation

@guitargeek

Copy link
Copy Markdown
Contributor

Update the code to avoid the following compiler warnings:

C:\ROOT-CI\src\roofit\roofit\test\testFitPerf.cxx(571,26): warning C4805: '|=': unsafe mix of type 'int' and type 'bool' in operation [C:\ROOT-CI\build\roofit\roofit\test\testFitPerf.vcxproj]
C:\ROOT-CI\src\roofit\roofit\test\testFitPerf.cxx(656,23): warning C4805: '|=': unsafe mix of type 'int' and type 'bool' in operation [C:\ROOT-CI\build\roofit\roofit\test\testFitPerf.vcxproj]
C:\ROOT-CI\src\roofit\roofit\test\testRooFit.cxx(212,23): warning C4805: '|=': unsafe mix of type 'int' and type 'bool' in operation [C:\ROOT-CI\build\roofit\roofit\test\testRooFitExe.vcxproj]

@guitargeek guitargeek requested a review from dpiparo June 9, 2026 06:05
@guitargeek guitargeek self-assigned this Jun 9, 2026
Update the code to avoid the following compiler warnings:

```
C:\ROOT-CI\src\roofit\roofit\test\testFitPerf.cxx(571,26): warning C4805: '|=': unsafe mix of type 'int' and type 'bool' in operation [C:\ROOT-CI\build\roofit\roofit\test\testFitPerf.vcxproj]
C:\ROOT-CI\src\roofit\roofit\test\testFitPerf.cxx(656,23): warning C4805: '|=': unsafe mix of type 'int' and type 'bool' in operation [C:\ROOT-CI\build\roofit\roofit\test\testFitPerf.vcxproj]
C:\ROOT-CI\src\roofit\roofit\test\testRooFit.cxx(212,23): warning C4805: '|=': unsafe mix of type 'int' and type 'bool' in operation [C:\ROOT-CI\build\roofit\roofit\test\testRooFitExe.vcxproj]
```
@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown

Test Results

    22 files      22 suites   3d 20h 22m 55s ⏱️
 3 864 tests  3 852 ✅   0 💤 12 ❌
76 324 runs  76 208 ✅ 104 💤 12 ❌

For more details on these failures, see this check.

Results for commit 4c47851.

♻️ This comment has been updated with latest results.

@guitargeek guitargeek merged commit 1d41195 into root-project:master Jun 9, 2026
55 of 58 checks passed
@guitargeek guitargeek deleted the windows_warnings branch June 9, 2026 13:25
@guitargeek

Copy link
Copy Markdown
Contributor Author

/backport to 6.40

@root-project-bot

Copy link
Copy Markdown

Preparing to backport PR #22540 to branch 6.40 requested by guitargeek

@root-project-bot

Copy link
Copy Markdown

Something went wrong with the creation of the PR to backport to 6.40: @guitargeek please see the logs

@root-project-bot

Copy link
Copy Markdown

This PR has been backported to

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants