[CPyCppyy] Introduce new public CreatePyValueFromMemory function#22512
Open
guitargeek wants to merge 1 commit into
Open
[CPyCppyy] Introduce new public CreatePyValueFromMemory function#22512guitargeek wants to merge 1 commit into
guitargeek wants to merge 1 commit into
Conversation
Test Results 22 files 22 suites 3d 17h 14m 21s ⏱️ For more details on these failures, see this check. Results for commit 30eb771. ♻️ This comment has been updated with latest results. |
vepadulano
reviewed
Jun 8, 2026
| // delete a previously created converter | ||
| CPYCPPYY_EXTERN void DestroyConverter(Converter* p); | ||
|
|
||
| // Build a Python value from a memory address using a Converter. |
Member
There was a problem hiding this comment.
To me it's not clear what happens to the input memory address. Is the Python value responsible for that memory after calling this function?
Add a CPyCppyy API function to build a Python value from a memory address using a Converter, with the possibility to build also an array proxy with a given shape. This is needed to implement the TTree pythonizations without including private CPyCppyy internals. In principle, the TTree pythonizations can now also be implemented completely in Python, which would be the next step.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a CPyCppyy API function to build a Python value from a memory address using a Converter, with the possibility to build also an array proxy with a given shape.
This is needed to implement the TTree pythonizations without including private CPyCppyy internals.
In principle, the TTree pythonizations can now also be implemented completely in Python, which would be the next step.