[mathtext] isolate from ROOT and sync with upstream#22476
Open
ferdymercury wants to merge 10 commits into
Open
[mathtext] isolate from ROOT and sync with upstream#22476ferdymercury wants to merge 10 commits into
ferdymercury wants to merge 10 commits into
Conversation
ferdymercury
commented
Jun 4, 2026
ferdymercury
commented
Jun 4, 2026
ferdymercury
commented
Jun 4, 2026
ferdymercury
commented
Jun 4, 2026
ferdymercury
commented
Jun 4, 2026
Test Results 22 files 22 suites 3d 15h 6m 4s ⏱️ For more details on these failures, see this check. Results for commit 1369aed. ♻️ This comment has been updated with latest results. |
Collaborator
Author
|
@bellenot does the Windows memmem backup implementation make sense to you? I am not sure if that is the reason for the CI failure |
Member
I'll have to check carefully to see what it does. BTW, did you also check this one ? https://github.com/git/git/blob/master/compat/memmem.c |
Member
|
@ferdymercury here are the errors: and: |
Co-authored-by: ferdymercury <ferdymercury@users.noreply.github.com>
avoid uninitalized warnings more fixes fix warning avoid uninitalized warnings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Variant of #22462 but upgrading to latest version (2016) and decoupling from ROOT libs
It's basically the version of @yslai at https://github.com/yslai/mathtext/tree/master/src/libmathtext with just a few patches on top to solve compilation errors.
PDF output might be potentially achievable since newer version of which has fontembedpdf.cc file