[mathtext] mv to builtin subdir for consistency#22462
Merged
Merged
Conversation
Test Results 22 files 22 suites 3d 11h 43m 42s ⏱️ Results for commit 76d6696. ♻️ This comment has been updated with latest results. |
Collaborator
Author
|
An expanded version of this PR that syncs with the 2016 upstream fork is here: #22476 and decouples builtin from ROOT |
Member
Difference is significant - one need test it before trying to adopt. But rest looks fine. |
linev
approved these changes
Jun 8, 2026
Collaborator
Author
Seems it only fails on Windows #22476 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as was done before with hard-coded builtin afterimage
There are some differences from ROOTs version (2012) with the upstream version (2016) but I do not know if it's worth to re-sync or even fully isolate from ROOT_LINKER_LIBRARY and have it as standalone lib.
upstream.diff.txt