[io] Write byte counts in streamer field#22430
Merged
jblomer merged 6 commits intoJun 9, 2026
Merged
Conversation
jblomer
changed the title
Test Results 22 files 22 suites 3d 8h 4m 40s ⏱️ For more details on these failures, see this check. Results for commit fe3c24b. ♻️ This comment has been updated with latest results. |
jblomer
force-pushed
the
streamer-field-bytecount-v2
branch
from
fd54941 to
3b67b13
Compare
hahnjo
reviewed
Jun 3, 2026
pcanal
reviewed
Jun 3, 2026
pcanal
reviewed
Jun 3, 2026
pcanal
reviewed
Jun 3, 2026
pcanal
reviewed
Jun 3, 2026
jblomer
force-pushed
the
streamer-field-bytecount-v2
branch
from
3b67b13 to
2f171ca
Compare
silverweed
reviewed
Jun 8, 2026
hahnjo
approved these changes
Jun 8, 2026
jblomer
force-pushed
the
streamer-field-bytecount-v2
branch
from
2f171ca to
fe3c24b
Compare
The version 0 and version 1 streamer fields are exactly the same for small objects (<=1GiB). For larger objects, the version 1 streamer field stores the byte count stack before the data. This is up to a future patch. For the moment, we assert that the streamed buffer is never >1GiB.
Add version 1 streamer field.
Uses RStreamerField as a test bed for (de-)serializing large objects with TBufferFile.
silverweed
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for streamer field v1, which writes the byte counts of large objects into the stream.
The first two commits should be backported.
Replaces #20608