Skip to content

S3 Possible bug: underlying response stream not disposed #92

Description

@timothycoleman

It appears that when reading from S3, the stream from the GetObjectResponse is not disposed.

https://github.com/robinrodricks/FluentStorage/blob/develop/FluentStorage.AWS/Blobs/AwsS3BlobStorage.cs#L195

Here the response.ResponseStream is wrapped in a FixedStream, which is returned to the user. But the FixedStream does not dispose the stream that is given to it.

I'm not sure if this is intentional for a reason that I don't understand, or, if it is a bug, whether the appropriate fix would be to have FixedStream dispose the stream it is passed, or have AwsS3BlobStorage pass a disposeCallback to the FixedStream constructor.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions