Skip to content

Issue handling Comfyroll prompt list outputs #83

@elson

Description

@elson

Hi, first off thank you for creating this node pack, it's been great for me!

I found an issue when using the Comfyroll prompt list node, the first output image is returned but subsequent ones are lost as the job is already marked as completed, see logs below.

I'm using ComfyUI-Distributed version 1.4.4.

Thanks in advance!!

Master logs

[Distributed] [Distributed][exec:exec_1779273821392_3569ab] Probing 1 workers with probe_concurrency=8
[Distributed] [Distributed][exec:exec_1779273821392_3569ab] Worker probe complete: active=1/1
[Distributed] Removed upstream reference 'images' from node 215 for delegate-only master prompt.
[Distributed] Inserted placeholder node 217 for collector 215 in delegate-only master prompt.
[Distributed] [Distributed][exec:exec_1779273821392_3569ab] Active distributed workers: Modal Worker (47adadd2-4756-4009-bcc5-41f7bb676dd1)
[Distributed] [Distributed][exec:exec_1779273821392_3569ab] Media sync for worker 47adadd2-4756-4009-bcc5-41f7bb676dd1: uploaded=1, skipped=0, missing=0, referenced=1
[Distributed] [Distributed][exec:exec_1779273821392_3569ab] Orchestration complete: prompt_id=7100e7a9-6cee-48c1-b3c0-4288964c6617, dispatched_workers=1, delegate_master=True
[Distributed] Master - Using existing queue for job exec_1779273823029_0e537e_215 (current size: 0)
[Distributed] Master - Job exec_1779273823029_0e537e_215: Delegate-only mode enabled, collecting exclusively from 1 workers
[Distributed] job_complete received canonical envelope - job_id: exec_1779273823029_0e537e_215, worker: 47adadd2-4756-4009-bcc5-41f7bb676dd1, batch_idx: 0, is_last: True, queue_size: 1
[Distributed] Master - Got canonical result from worker 47adadd2-4756-4009-bcc5-41f7bb676dd1, image 0, is_last=True
[Distributed] Master - Job exec_1779273823029_0e537e_215 complete. Combined 1 images total (master: 0, workers: 1)
Prompt executed in 27.97 seconds
[Distributed] API Error [404]: job not initialized

Remote logs

Model Flux2 prepared for dynamic VRAM loading. 8996MB Staged. 0 patches attached.

100%|██████████| 4/4 [00:02<00:00,  1.23it/s]
100%|██████████| 4/4 [00:02<00:00,  1.99it/s]
Model Flux2 prepared for dynamic VRAM loading. 8996MB Staged. 0 patches attached.

100%|██████████| 4/4 [00:03<00:00,  1.22it/s]
100%|██████████| 4/4 [00:03<00:00,  1.22it/s]
Model AutoencoderKL prepared for dynamic VRAM loading. 119MB Staged. 0 patches attached.
Model AutoencoderKL prepared for dynamic VRAM loading. 119MB Staged. 0 patches attached.
[Distributed] Worker - Failed to send canonical image envelope to master: 404, message='Not Found', url='https://learning-inch-availability-toll.trycloudflare.com/distributed/job_complete'
!!! Exception during processing !!! 404, message='Not Found', url='https://learning-inch-availability-toll.trycloudflare.com/distributed/job_complete'
Traceback (most recent call last):
  File "/root/comfy/ComfyUI/execution.py", line 534, in execute
    output_data, output_ui, has_subgraph, has_pending_tasks = await get_output_data(prompt_id, unique_id, obj, input_data_all, execution_block_cb=execution_block_cb, pre_execute_cb=pre_execute_cb, v3_data=v3_data)
                                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/root/comfy/ComfyUI/execution.py", line 334, in get_output_data
    return_values = await _async_map_node_over_list(prompt_id, unique_id, obj, input_data_all, obj.FUNCTION, allow_interrupt=True, execution_block_cb=execution_block_cb, pre_execute_cb=pre_execute_cb, v3_data=v3_data)
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/root/comfy/ComfyUI/execution.py", line 308, in _async_map_node_over_list
    await process_inputs(input_dict, i)
  File "/root/comfy/ComfyUI/execution.py", line 296, in process_inputs
    result = f(**inputs)
             ^^^^^^^^^^^
  File "/root/comfy/ComfyUI/custom_nodes/ComfyUI-Distributed/nodes/collector.py", line 68, in run
    result = run_async_in_server_loop(
             ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/root/comfy/ComfyUI/custom_nodes/ComfyUI-Distributed/utils/async_helpers.py", line 53, in run_async_in_server_loop
    raise error
  File "/root/comfy/ComfyUI/custom_nodes/ComfyUI-Distributed/utils/async_helpers.py", line 38, in wrapper
    result = await coro
             ^^^^^^^^^^
  File "/root/comfy/ComfyUI/custom_nodes/ComfyUI-Distributed/nodes/collector.py", line 242, in execute
    await self.send_batch_to_master(images, audio, multi_job_id, master_url, worker_id)
  File "/root/comfy/ComfyUI/custom_nodes/ComfyUI-Distributed/nodes/collector.py", line 115, in send_batch_to_master
    response.raise_for_status()
  File "/usr/local/lib/python3.12/site-packages/aiohttp/client_reqrep.py", line 636, in raise_for_status
    raise ClientResponseError(
aiohttp.client_exceptions.ClientResponseError: 404, message='Not Found', url='https://learning-inch-availability-toll.trycloudflare.com/distributed/job_complete'

Prompt executed in 39.36 seconds

Workflow

distributed-list-issue.json

Image

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions