From 2ac26c5800381b9be8ea73c2cea7fbeacfc970bf Mon Sep 17 00:00:00 2001 From: Jimisola Laursen Date: Thu, 20 Aug 2026 02:37:15 +0200 Subject: [PATCH 1/2] fix(renovate): migrate deprecated match fields and validate strictly matchPackagePrefixes and matchPackagePatterns are deprecated. Replaced with the matchPackageNames forms that renovate-config-validator itself produces, so the matching semantics are Renovate's own migration rather than a hand translation. The validation workflow ran without --strict, where a config needing migration exits 0 -- which is why this went unnoticed. Adding --strict makes the next deprecation fail the check instead of passing quietly. Signed-off-by: Jimisola Laursen --- .github/renovate.json5 | 8 ++++---- .github/workflows/common-validate-renovate.yml | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/renovate.json5 b/.github/renovate.json5 index f1c4575..375ae0f 100644 --- a/.github/renovate.json5 +++ b/.github/renovate.json5 @@ -178,9 +178,9 @@ { matchManagers: ["maven", "gradle"], - matchPackagePrefixes: [ - "org.springframework", - "org.springframework.security" + matchPackageNames: [ + "org.springframework{/,}**", + "org.springframework.security{/,}**" ], groupName: "spring ecosystem", addLabels: ["renovate-type-spring"], @@ -305,7 +305,7 @@ { matchManagers: ["maven", "gradle"], groupName: "{{groupId}} packages", - matchPackagePatterns: [".*"], + matchPackageNames: ["/.*/"], } ], } diff --git a/.github/workflows/common-validate-renovate.yml b/.github/workflows/common-validate-renovate.yml index 8d9ca11..ea975de 100644 --- a/.github/workflows/common-validate-renovate.yml +++ b/.github/workflows/common-validate-renovate.yml @@ -30,4 +30,4 @@ jobs: docker run --rm \ -v "$GITHUB_WORKSPACE:/repo" \ "renovate/renovate:$VERSION" \ - renovate-config-validator "/repo/$CONFIG_PATH" + renovate-config-validator --strict "/repo/$CONFIG_PATH" From de74ad170bbe9481eb67b055f40f5a02e43bd37d Mon Sep 17 00:00:00 2001 From: Jimisola Laursen Date: Thu, 20 Aug 2026 02:38:40 +0200 Subject: [PATCH 2/2] fix(ci): run the validation check when the check itself changes The workflow triggered only on .github/renovate.json5, so a PR editing either validation workflow reported no checks at all. Signed-off-by: Jimisola Laursen --- .github/workflows/validate-renovate.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/workflows/validate-renovate.yml b/.github/workflows/validate-renovate.yml index 3b03023..2f60b6a 100644 --- a/.github/workflows/validate-renovate.yml +++ b/.github/workflows/validate-renovate.yml @@ -4,9 +4,14 @@ on: push: paths: - ".github/renovate.json5" + # so a change to the check itself is exercised by the check + - ".github/workflows/validate-renovate.yml" + - ".github/workflows/common-validate-renovate.yml" pull_request: paths: - ".github/renovate.json5" + - ".github/workflows/validate-renovate.yml" + - ".github/workflows/common-validate-renovate.yml" permissions: {}