PagerDuty: document parameters passthrough and templating gotcha#234
Merged
Conversation
Add a callout explaining that bare strings under `extension request`
are interpreted as gjson paths and silently dropped if they don't
resolve — wrap literals in `{{ "..." }}`. Add a section describing
the new `parameters` block (custom_details, links, images, timestamp,
client, client_url, dedup_key) and a worked example showing a
clickable link back to LimaCharlie and a dedup_key tied to the
detection.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
maximelb
added
the
to-code-review
- alternate-targets.md: rename `pagerduty` → `ext-pagerduty` and switch the request body key from the legacy `request:` to `extension request:`. - dr-rule-building-guidebook.md: rename `pagerduty` → `ext-pagerduty` and add the required `source` field so the example actually validates (the extension requires summary + source + severity). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the PagerDuty extension page with two things that came out of a recent incident:
extension requestare evaluated as gjson paths and silently dropped if they don't resolve. Wrap literals in{{ "..." }}. This is what caused customers to hitmissing one of sourceeven though the rule clearly hadsource: limacharlie.io.parameterspassthrough block being added in ext-pagerduty#35 —custom_details,links,images,timestamp,client,client_url,dedup_key— with a worked example showing a clickable link back to LimaCharlie and a dedup_key tied to the detection.Depends on ext-pagerduty#35 landing first.
Test plan
🤖 Generated with Claude Code