fix type and lint warnings

Author: Archmonger

pyproject.toml

@@ -198,7 +198,7 @@ deploy_develop = ["cd docs && mike deploy --push develop"]
 ################################
 
 [tool.hatch.envs.python]
-extra-dependencies = ["django-stubs", "channels-redis", "pyright"]
+extra-dependencies = ["django-stubs", "channels-redis", "pyright", "jinja2"]
 
 [tool.hatch.envs.python.scripts]
 type_check = ["pyright src"]

src/reactpy_django/templatetags/jinja.py

@@ -27,6 +27,7 @@
     from jinja2 import Environment
     from reactpy_django.templatetags.jinja import ReactPyExtension
 
+
     def environment(**options):
         env = Environment(**options)
         env.add_extension(ReactPyExtension)
@@ -35,26 +36,30 @@ def environment(**options):
 
 from __future__ import annotations
 
-import json
 from logging import getLogger
 from typing import TYPE_CHECKING
 
 from django.template import RequestContext, loader
-from django.utils.safestring import mark_safe
 from jinja2 import pass_context
 from jinja2.ext import Extension
-from jinja2.runtime import Context
 
 from reactpy_django.templatetags.reactpy import (
     COMPONENT_TEMPLATE,
     PYSCRIPT_COMPONENT_TEMPLATE,
     PYSCRIPT_SETUP_TEMPLATE,
+)
+from reactpy_django.templatetags.reactpy import (
     component as django_component_tag,
+)
+from reactpy_django.templatetags.reactpy import (
     pyscript_component as django_pyscript_component_tag,
+)
+from reactpy_django.templatetags.reactpy import (
     pyscript_setup as django_pyscript_setup_tag,
 )
 
 if TYPE_CHECKING:
+    from jinja2.runtime import Context
     from reactpy.types import Component, VdomDict
 
 _logger = getLogger(__name__)
@@ -75,8 +80,6 @@ class ReactPyExtension(Extension):
     function expansions.
     """
 
-    tags = {}
-
     def __init__(self, environment):
         super().__init__(environment)
         environment.globals["component"] = self._component
@@ -111,7 +114,7 @@ def _component(
         """
         request = jinja_context.parent.get("request")
         if request is None:
-            _logger.exception(
+            _logger.error(
                 "Cannot render a ReactPy component in a Jinja2 template without a "
                 "request object. Ensure the 'django.template.context_processors.request' "
                 "context processor is enabled for your Jinja2 backend."
@@ -159,10 +162,7 @@ def _pyscript_component(
         """
         request = jinja_context.parent.get("request")
         if request is None:
-            _logger.exception(
-                "Cannot render a PyScript component in a Jinja2 template without a "
-                "request object."
-            )
+            _logger.error("Cannot render a PyScript component in a Jinja2 template without a request object.")
             return ""
 
         django_context = RequestContext(

tests/test_app/__init__.py

@@ -15,13 +15,10 @@
         cwd=str(js_dir),
         check=True,
     )
-else:
-    # Verify that JS artifacts already exist so we don't silently skip a needed build
-    if not (static_dir / "index.js").exists():
-        raise RuntimeError(
-            "bun is not installed and JS artifacts are missing. "
-            f"Run 'bun install && bun build' in {js_dir} first."
-        )
+# Verify that JS artifacts already exist so we don't silently skip a needed build
+elif not (static_dir / "index.js").exists():
+    msg = f"bun is not installed and JS artifacts are missing. Run 'bun install && bun build' in {js_dir} first."
+    raise RuntimeError(msg)
 
 
 # Make sure the test environment is always using the latest JS

tests/test_app/tests/test_jinja.py

@@ -40,6 +40,7 @@ class Jinja2ComponentTests(TestCase):
     def test_component_function_available(self):
         """The component function should be available in Jinja2 templates."""
         from jinja2 import Environment
+
         from reactpy_django.templatetags.jinja import ReactPyExtension
 
         env = Environment()
@@ -52,6 +53,7 @@ def test_component_function_available(self):
     def test_pyscript_component_function_available(self):
         """The pyscript_component function should be available in Jinja2 templates."""
         from jinja2 import Environment
+
         from reactpy_django.templatetags.jinja import ReactPyExtension
 
         env = Environment()
@@ -64,6 +66,7 @@ def test_pyscript_component_function_available(self):
     def test_pyscript_setup_function_available(self):
         """The pyscript_setup function should be available in Jinja2 templates."""
         from jinja2 import Environment
+
         from reactpy_django.templatetags.jinja import ReactPyExtension
 
         env = Environment()
@@ -78,9 +81,7 @@ def test_jinja_component_renders_without_error(self):
         from django.template import engines
 
         jinja2_engine = engines["jinja2"]
-        template = jinja2_engine.from_string(
-            "{{ component('test_app.components.hello_world') }}"
-        )
+        template = jinja2_engine.from_string("{{ component('test_app.components.hello_world') }}")
         rendered = template.render({})
         # The rendered output should be a string of some sort
         assert isinstance(rendered, str)
@@ -105,8 +106,6 @@ class Jinja2ViewTests(TestCase):
     def test_jinja_base_template_view_status(self):
         """The Jinja2 base template view should return HTTP 200."""
         # Note: These tests require the Jinja2 settings module
-        pass
 
     def test_jinja_errors_template_view_status(self):
         """The Jinja2 errors template view should return HTTP 200."""
-        pass