Delete TextAncestor compatibility shim#56813
Closed
yaminyassin wants to merge 1 commit into
Closed
Conversation
The shim file `packages/react-native/Libraries/Text/TextAncestor.js` was kept solely to support react-strict-dom's deep import. The file's own comment carried a TODO from @huntie to delete it once the cross-repo reference was fixed. react-strict-dom has now switched to the public `unstable_TextAncestorContext` API (react/react-strict-dom#477), exposed in #52368. No internal React Native consumers reference this shim — both `packages/react-native/index.js` and `index.js.flow` import `./Libraries/Text/TextAncestorContext` directly. ## Changelog: [INTERNAL] - Delete TextAncestor compatibility shim
meta-cla
Bot
added
the
CLA Signed
Member
|
Let's see if this passes CI once imported 😄 |
Author
|
facebook/react-strict-dom#477 PR merged! @huntie could you review this one |
|
@huntie has imported this pull request. If you are a Meta employee, you can view this in D108144363. |
cortinico
approved these changes
Jun 10, 2026
cortinico
left a comment
cortinico
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-opened version of #56813 after I had to delete and recreate my fork.
This deletes
packages/react-native/Libraries/Text/TextAncestor.js, a compatibility shim for the oldreact-strict-domdeep import.react-strict-domnow uses the publicunstable_TextAncestorContextAPI instead.Changelog
[Internal] [Removed] - Delete
Libraries/Text/TextAncestorcompatibility shimTest Plan
Validated locally on
chore/delete-text-ancestor-shim:All checks passed. Jest passed with 275 test suites, 5635 tests, 1 skipped, and 1798 snapshots.