extension/llm/server: warm append-only session resume (V2b.1)#20160
Open
mergennachin wants to merge 1 commit into
Open
extension/llm/server: warm append-only session resume (V2b.1)#20160mergennachin wants to merge 1 commit into
mergennachin wants to merge 1 commit into
Conversation
[ghstack-poisoned]
Contributor
Author
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20160
Note: Links to docs will display an error until the docs builds have been completed. ❌ 6 New Failures, 3 PendingAs of commit b930b9f with merge base eeb0646 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on the isolated named sessions: a named session now keeps its decoded
context across requests. When the next request's prompt tokens are an exact
prefix extension of the session's resident tokens (the same conversation plus a
new turn), the worker prefills ONLY the new suffix -- continuing the
KV/recurrent state in place -- instead of resetting and re-prefilling the whole
prompt. The match is exact-token (never re-tokenized text), so it is always
correct: a token mismatch, a stop-string trim, or a prior error falls back to a
full reset + prefill. This is per-session resume, not global prefix caching.
The decision lives in a dependency-free pure helper (worker_prefill_plan.h,
unit-tested standalone); worker_loop.h tracks each session's resident token ids
(invariant: resident size == session position) and executes the plan, and the
doneevent reports reused_prompt_tokens / prefilled_prompt_tokens /session_reset_reason for measuring the hit rate. POST /v1/sessions/{id}/reset
clears a session's context while keeping its slot. The qwen worker's
--warm_resume (serve.py --no-warm-resume) gates the behavior for A/B measurement.
Review order: worker_prefill_plan.h + its test; then worker_loop.h (resident
tracking + plan execution); then the control-plane reset op + metrics; then docs.
Part of #20001