Skip to content

gh-151042: venv: Pass VIRTUAL_ENV through cygpath inside fish on Windows#151043

Open
LuNoX wants to merge 2 commits into
python:mainfrom
LuNoX:fix-fish-activation-on-windows-breaks-PATH
Open

gh-151042: venv: Pass VIRTUAL_ENV through cygpath inside fish on Windows#151043
LuNoX wants to merge 2 commits into
python:mainfrom
LuNoX:fix-fish-activation-on-windows-breaks-PATH

Conversation

@LuNoX

@LuNoX LuNoX commented Jun 7, 2026

Copy link
Copy Markdown

gh-151042: Fixed venv exporting mixed path styles to PATH on Windows inside fish (via Cygwin, MinGW or MSYS2)

This PR mirrors the changes from gh-103325, gh-125399 and gh-112508 to the fish activation script.

@python-cla-bot

python-cla-bot Bot commented Jun 7, 2026

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app

bedevere-app Bot commented Jun 7, 2026

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app

bedevere-app Bot commented Jun 7, 2026

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@LuNoX LuNoX force-pushed the fix-fish-activation-on-windows-breaks-PATH branch from 43977d2 to afb462e Compare June 7, 2026 13:43
@bedevere-app

bedevere-app Bot commented Jun 7, 2026

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@LuNoX LuNoX force-pushed the fix-fish-activation-on-windows-breaks-PATH branch from 9ac5922 to 0694664 Compare June 7, 2026 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant