gh-118716: Do not fail on non ASCII local part when parsing addr_spec

RFC 6530 allows UTF-8 strings in the local part.

Author: cedk

Lib/email/headerregistry.py

@@ -45,8 +45,9 @@ def __init__(self, display_name='', username='', domain='', addr_spec=None):
                 raise ValueError("Invalid addr_spec; only '{}' "
                                  "could be parsed from '{}'".format(
                                     a_s, addr_spec))
-            if a_s.all_defects:
-                raise a_s.all_defects[0]
+            for defect in a_s.all_defects:
+                if not isinstance(defect, errors.NonASCIILocalPartDefect):
+                    raise defect
             username = a_s.local_part
             domain = a_s.domain
         self._display_name = display_name

Lib/test/test_email/test_headerregistry.py

@@ -1492,17 +1492,20 @@ def test_quoting(self):
         self.assertEqual(str(a), '"Sara J." <"bad name"@example.com>')
 
     def test_il8n(self):
-        a = Address('Éric', 'wok', 'exàmple.com')
+        a = Address('Éric', 'wők', 'exàmple.com')
         self.assertEqual(a.display_name, 'Éric')
-        self.assertEqual(a.username, 'wok')
+        self.assertEqual(a.username, 'wők')
         self.assertEqual(a.domain, 'exàmple.com')
-        self.assertEqual(a.addr_spec, 'wok@exàmple.com')
-        self.assertEqual(str(a), 'Éric <wok@exàmple.com>')
+        self.assertEqual(a.addr_spec, 'wők@exàmple.com')
+        self.assertEqual(str(a), 'Éric <wők@exàmple.com>')
 
-    # XXX: there is an API design issue that needs to be solved here.
-    #def test_non_ascii_username_raises(self):
-    #    with self.assertRaises(ValueError):
-    #        Address('foo', 'wők', 'example.com')
+    def test_non_ascii_username_in_addr_spec(self):
+        a = Address('foo', addr_spec='wők@example.com')
+        self.assertEqual(a.display_name, 'foo')
+        self.assertEqual(a.username, 'wők')
+        self.assertEqual(a.domain, 'example.com')
+        self.assertEqual(a.addr_spec, 'wők@example.com')
+        self.assertEqual(str(a), 'foo <wők@example.com>')
 
     def test_crlf_in_constructor_args_raises(self):
         cases = (
@@ -1523,10 +1526,6 @@ def test_crlf_in_constructor_args_raises(self):
             with self.subTest(kwargs=kwargs), self.assertRaisesRegex(ValueError, "invalid arguments"):
                 Address(**kwargs)
 
-    def test_non_ascii_username_in_addr_spec_raises(self):
-        with self.assertRaises(ValueError):
-            Address('foo', addr_spec='wők@example.com')
-
     def test_address_addr_spec_and_username_raises(self):
         with self.assertRaises(TypeError):
             Address('foo', username='bing', addr_spec='bar@baz')