You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I understand your intents, but it seems such format is not follow IntelHex-8 standard. Do you have any links or pdf document with hex word format explanations?
Anyway, I don't like the fact you changed the most time-critical function (decode_record). I think it's better to copy decode_record method entirely into new class and make modifications there. Also the IntelHex project is relying on unit tests. We need some unit tests for your class with some simple example of such word file.
Please, rework your class, add unit tests and write some text for manual.
Sorry for not reviewing your patch a year ago. If you don't need it anymore - please say so.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for issue: #32