Skip to content

Pin rustc and toolchain to 1.86#475

Merged
thomasp85 merged 3 commits into
mainfrom
issue-469-pin-rust
Jun 18, 2026
Merged

Pin rustc and toolchain to 1.86#475
thomasp85 merged 3 commits into
mainfrom
issue-469-pin-rust

Conversation

@thomasp85

Copy link
Copy Markdown
Collaborator

Fix #469

@thomasp85 thomasp85 requested a review from teunbrand June 16, 2026 06:27

@teunbrand teunbrand left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM but I'm a bit bothered by having to mix different versions in the same build/publish workflows. Is there a reason we must keep adbc_datafusion >= 53.1.0 and cannot downgrade this version to be compatible with the rest?

@thomasp85

Copy link
Copy Markdown
Collaborator Author

We can't avoid te split for WASM, and forcing the rust version there is also non-sensical since wasm doesn't matter for cran. As for the adbc it is sadly a game of whack-a-mole since adbc depend on crates that have silent 1.88 requirements... we would have to pin all of these as well to get us there and then carry that burden onwards

@thomasp85 thomasp85 merged commit a614297 into main Jun 18, 2026
2 checks passed
@eitsupi

eitsupi commented Jun 19, 2026

Copy link
Copy Markdown

adbc depend on crates that have silent 1.88 requirements

I think this may be a misunderstanding.
The MSRV of adbc_core 0.23.0 is 1.81.0.
https://github.com/apache/arrow-adbc/blob/efdc10ba93f7ae31a7beeb801c13fdcd15f01c6e/rust/Cargo.toml#L26

This has been rigorously tested on CI and is fully guaranteed.

If you're struggling with MSRV for transitional dependencies, I think it's worth considering using Cargo resolver 3.
Resolver 3 handles dependency resolution with MSRV in mind.
https://doc.rust-lang.org/edition-guide/rust-2024/cargo-resolver.html


Also, please note that adbc_datafusion may be removed from crates.io.
If the DataFusion build is causing constraints, I recommend rewriting the tests.
apache/arrow-adbc#4377 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pin Rust to 1.86

3 participants