Pin rustc and toolchain to 1.86#475
Conversation
teunbrand
left a comment
There was a problem hiding this comment.
Mostly LGTM but I'm a bit bothered by having to mix different versions in the same build/publish workflows. Is there a reason we must keep adbc_datafusion >= 53.1.0 and cannot downgrade this version to be compatible with the rest?
|
We can't avoid te split for WASM, and forcing the rust version there is also non-sensical since wasm doesn't matter for cran. As for the adbc it is sadly a game of whack-a-mole since adbc depend on crates that have silent 1.88 requirements... we would have to pin all of these as well to get us there and then carry that burden onwards |
I think this may be a misunderstanding. This has been rigorously tested on CI and is fully guaranteed. If you're struggling with MSRV for transitional dependencies, I think it's worth considering using Cargo resolver 3. Also, please note that adbc_datafusion may be removed from crates.io. |
Fix #469