ext/phar: stream context options are always stored in an array#22234
Merged
Conversation
These cannot be objects and thus there is no need to use HASH_OF. Can be double checked looking at stream_context_set_option() and stream_context_set_options() functions
ndossche
approved these changes
Jun 5, 2026
LamentXU123
approved these changes
Jun 5, 2026
Contributor
LamentXU123
left a comment
LamentXU123
left a comment
There was a problem hiding this comment.
The SNMP CI on windows has a very high possibility of failing. I tried to solve this before but it turns out the reason is kind of complicated. Might need more people to look into this stuff in the future or this will keep bothering unrelated PRs.
Contributor
|
Anyway, re-running the failed job to get rid of the SNMP failure. |
devnexen
reviewed
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These cannot be objects and thus there is no need to use HASH_OF.
Can be double-checked looking at stream_context_set_option() and stream_context_set_options() functions.
As you last edited this Nora can you have a look, it seems you conflated stream filter parameters (which can be objects) with the stream context options which can only be an array.