Do not pass $name to Command::__construct() to allow lazy loading

Author: benr77

src/Command/DebugTasksCommand.php

@@ -29,12 +29,11 @@ class DebugTasksCommand extends Command
     private $taskExecutionRepository;
 
     /**
-     * @param string $name
      * @param TaskExecutionRepositoryInterface $taskExecutionRepository
      */
-    public function __construct($name, TaskExecutionRepositoryInterface $taskExecutionRepository)
+    public function __construct(TaskExecutionRepositoryInterface $taskExecutionRepository)
     {
-        parent::__construct($name);
+        parent::__construct();
 
         $this->taskExecutionRepository = $taskExecutionRepository;
     }

src/Command/ExecuteCommand.php

@@ -45,17 +45,15 @@ class ExecuteCommand extends Command
     private $eventDispatcher;
 
     /**
-     * @param string $name
      * @param TaskHandlerFactoryInterface $handlerFactory
      * @param TaskExecutionRepositoryInterface $executionRepository
      */
     public function __construct(
-        $name,
         TaskHandlerFactoryInterface $handlerFactory,
         TaskExecutionRepositoryInterface $executionRepository,
         EventDispatcherInterface $dispatcher
     ) {
-        parent::__construct($name);
+        parent::__construct();
 
         $this->handlerFactory = $handlerFactory;
         $this->executionRepository = $executionRepository;

src/Command/RunCommand.php

@@ -33,13 +33,12 @@ class RunCommand extends Command
     private $scheduler;
 
     /**
-     * @param string $name
      * @param TaskRunnerInterface $runner
      * @param TaskSchedulerInterface $scheduler
      */
-    public function __construct($name, TaskRunnerInterface $runner, TaskSchedulerInterface $scheduler)
+    public function __construct(TaskRunnerInterface $runner, TaskSchedulerInterface $scheduler)
     {
-        parent::__construct($name);
+        parent::__construct();
 
         $this->runner = $runner;
         $this->scheduler = $scheduler;

src/Command/RunHandlerCommand.php

@@ -28,12 +28,11 @@ class RunHandlerCommand extends Command
     private $handlerFactory;
 
     /**
-     * @param string $name
      * @param TaskHandlerFactoryInterface $handlerFactory
      */
-    public function __construct($name, TaskHandlerFactoryInterface $handlerFactory)
+    public function __construct(TaskHandlerFactoryInterface $handlerFactory)
     {
-        parent::__construct($name);
+        parent::__construct();
 
         $this->handlerFactory = $handlerFactory;
     }

src/Command/ScheduleSystemTasksCommand.php

@@ -40,20 +40,18 @@ class ScheduleSystemTasksCommand extends Command
     private $taskExecutionRepository;
 
     /**
-     * @param string $name
      * @param array $systemTasks
      * @param TaskSchedulerInterface $scheduler
      * @param SystemTaskRepositoryInterface $taskRepository
      * @param TaskExecutionRepositoryInterface $taskExecutionRepository
      */
     public function __construct(
-        $name,
         array $systemTasks,
         TaskSchedulerInterface $scheduler,
         SystemTaskRepositoryInterface $taskRepository,
         TaskExecutionRepositoryInterface $taskExecutionRepository
     ) {
-        parent::__construct($name);
+        parent::__construct();
 
         $this->systemTasks = $systemTasks;
         $this->scheduler = $scheduler;

src/Command/ScheduleTaskCommand.php

@@ -29,12 +29,11 @@ class ScheduleTaskCommand extends Command
     private $scheduler;
 
     /**
-     * @param string $name
      * @param TaskSchedulerInterface $runner
      */
-    public function __construct($name, TaskSchedulerInterface $runner)
+    public function __construct(TaskSchedulerInterface $runner)
     {
-        parent::__construct($name);
+        parent::__construct();
 
         $this->scheduler = $runner;
     }

src/Resources/config/command.xml

@@ -4,7 +4,6 @@
            xsi:schemaLocation="http://symfony.com/schema/dic/services http://symfony.com/schema/dic/services/services-1.0.xsd">
     <services>
         <service id="task.command.run" class="Task\TaskBundle\Command\RunCommand" public="true">
-            <argument type="string">task:run</argument>
             <argument type="service" id="task.runner"/>
             <argument type="service" id="task.scheduler"/>
             <!-- add entity_manager if doctrine storage is enabled -->
@@ -13,14 +12,12 @@
         </service>
 
         <service id="task.command.run_handler" class="Task\TaskBundle\Command\RunHandlerCommand" public="true">
-            <argument type="string">task:run:handler</argument>
             <argument type="service" id="task.handler.factory"/>
 
             <tag name="console.command" command="task:run:handler"/>
         </service>
 
         <service id="task.command.executor" class="Task\TaskBundle\Command\ExecuteCommand" public="true">
-            <argument type="string">task:execute</argument>
             <argument type="service" id="task.handler.factory"/>
             <argument type="service" id="task.storage.task_execution"/>
             <argument type="service" id="event_dispatcher"/>
@@ -29,15 +26,13 @@
         </service>
 
         <service id="task.command.schedule_task" class="Task\TaskBundle\Command\ScheduleTaskCommand" public="true">
-            <argument type="string">task:schedule</argument>
             <argument type="service" id="task.scheduler"/>
             <!-- add entity_manager if doctrine storage is enabled -->
 
             <tag name="console.command" command="task:schedule"/>
         </service>
 
         <service id="task.command.debug_tasks" class="Task\TaskBundle\Command\DebugTasksCommand" public="true">
-            <argument type="string">debug:tasks</argument>
             <argument type="service" id="task.storage.task_execution"/>
 
             <tag name="console.command" command="debug:tasks"/>

src/Resources/config/storage/doctrine.xml

@@ -18,13 +18,12 @@
         <service id="task.storage.task_execution" alias="task.repository.task_execution" public="true"/>
 
         <service id="task.command.schedule_system_tasks" class="Task\TaskBundle\Command\ScheduleSystemTasksCommand" public="true">
-            <argument type="string">task:schedule:system-tasks</argument>
             <argument>%task.system_tasks%</argument>
             <argument type="service" id="task.scheduler"/>
             <argument type="service" id="task.repository.task"/>
             <argument type="service" id="task.storage.task_execution"/>
 
-            <tag name="console.command"/>
+            <tag name="console.command" command="task:schedule:system-tasks"/>
         </service>
     </services>
 </container>

tests/Unit/Command/ScheduleSystemTasksCommandTest.php

@@ -52,7 +52,6 @@ protected function setUp(): void
     protected function createCommand(array $systemTasks)
     {
         return new ScheduleSystemTasksCommand(
-            'task:schedule:system-tasks',
             $systemTasks,
             $this->scheduler->reveal(),
             $this->taskRepository->reveal(),