test(adapter-bundle): cover custom factories and Memcached options

Author: cryptiklemur

tests/Unit/DependencyInjection/CacheAdapterExtensionTest.php

@@ -16,6 +16,7 @@
 use Cache\Adapter\PHPArray\ArrayCachePool;
 use Cache\AdapterBundle\CacheAdapterBundle;
 use Cache\AdapterBundle\DependencyInjection\CacheAdapterExtension;
+use Cache\AdapterBundle\DependencyInjection\CompilerPass\AdapterFactoryCompilerPass;
 use Cache\AdapterBundle\DummyAdapter;
 use Cache\AdapterBundle\Exception\ConfigurationException;
 use Cache\AdapterBundle\Factory\AbstractAdapterFactory;
@@ -63,6 +64,15 @@ public function testItResolvesApplicationDefinedFactoryServicesAfterExtensionsMe
         self::assertInstanceOf(ArrayCachePool::class, $container->get('cache.provider.custom'));
     }
 
+    public function testFactoryCompilerPassIgnoresContainersWithoutFactoryConfiguration()
+    {
+        $container = new ContainerBuilder();
+
+        (new AdapterFactoryCompilerPass())->process($container);
+
+        self::assertFalse($container->hasParameter('cache_adapter.factory_configurations'));
+    }
+
     public function testAliasProvidersExists()
     {
         $providers = ['foo' => ['factory' => 'cache.factory.array', 'aliases' => ['alias_http']]];

tests/Unit/Factory/FactoryBehaviorTest.php

@@ -154,7 +154,18 @@ public function testMemcachedFactoryPreservesTagSupportWhenNamespaced()
     public function testMemcachedDriverOptionsOverridePoolDefaults()
     {
         if (class_exists(\Memcached::class)) {
-            $this->markTestSkipped('This test uses a local Memcached stub.');
+            $defaultId = 'adapter-bundle-default-'.bin2hex(random_bytes(8));
+            (new MemcachedFactory())->createAdapter(['persistent_id' => $defaultId]);
+            self::assertTrue((bool) (new \Memcached($defaultId))->getOption(\Memcached::OPT_BINARY_PROTOCOL));
+
+            $configuredId = 'adapter-bundle-configured-'.bin2hex(random_bytes(8));
+            (new MemcachedFactory())->createAdapter([
+                'persistent_id' => $configuredId,
+                'driver_options' => ['Memcached::OPT_BINARY_PROTOCOL' => false],
+            ]);
+            self::assertFalse((bool) (new \Memcached($configuredId))->getOption(\Memcached::OPT_BINARY_PROTOCOL));
+
+            return;
         }
 
         eval('namespace { class Memcached { public const OPT_BINARY_PROTOCOL = 18; private array $servers = []; public function __construct(?string $persistentId = null) {} public function getServerList(): array { return $this->servers; } public function addServer(mixed $host, mixed $port, mixed $weight = 0): bool { $this->servers[] = ["host" => $host, "port" => $port]; return true; } public function setOption(int $option, mixed $value): bool { \\Cache\\AdapterBundle\\Tests\\Unit\\Factory\\MemcachedOptionRecorder::$options[$option] = $value; return true; } } }');