Skip to content

fix(pkg/linux): pin psycopg-c build to x86-64 v1 baseline #10017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
asheshv wants to merge 1 commit into
base: master
Choose a base branch
from
+22 −2
Open

fix(pkg/linux): pin psycopg-c build to x86-64 v1 baseline #10017

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 22 additions & 2 deletions pkg/linux/build-functions.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,28 @@ _create_python_virtualenv() {
pip3 install --upgrade pip
pip3 install wheel

# Install the requirements
pip3 install --force-reinstall --no-cache-dir --no-binary psycopg -r "${SOURCEDIR}/requirements.txt"
# Install the requirements.
#
# psycopg is built from source against the system libpq (see
# --no-binary psycopg). Pin the C extension to the x86-64 v1
# baseline so the resulting .so runs on every x86_64 CPU we
# claim to support. Without this, gcc on a modern build host
# may emit AVX2/BMI2/FMA instructions that SIGILL on older
# CPUs (Ivy Bridge and earlier) and on default Proxmox kvm64
# VMs at psycopg_c.pq module-load time. Issue #9935.
#
# The flags are scoped to this pip invocation so they don't
# leak into any other build steps in the same shell. Other
# arches build with their distro defaults.
if [ "$(uname -m)" = "x86_64" ]; then
CFLAGS="${CFLAGS:-} -O2 -march=x86-64 -mtune=generic" \
CXXFLAGS="${CXXFLAGS:-} -O2 -march=x86-64 -mtune=generic" \
pip3 install --force-reinstall --no-cache-dir \
--no-binary psycopg -r "${SOURCEDIR}/requirements.txt"
else
pip3 install --force-reinstall --no-cache-dir \
--no-binary psycopg -r "${SOURCEDIR}/requirements.txt"
fi

# Fixup the paths in the venv activation scripts
sed -i 's/VIRTUAL_ENV=.*/VIRTUAL_ENV="\/usr\/pgadmin4\/venv"/g' venv/bin/activate
Expand Down
Loading