From 5792e9ea7e531faf0978ed13fdeac32265189088 Mon Sep 17 00:00:00 2001 From: Peter Corke Date: Fri, 3 Jul 2026 07:37:45 +1000 Subject: [PATCH 1/3] ci: split docs-deploy from docs-build to avoid false Pages failures on PRs A job-level `environment: github-pages` triggers a deployment attempt against that environment as soon as the job starts, regardless of the step-level `if: github.ref == 'refs/heads/main'` guard on the actual deploy step. The github-pages environment's deployment protection rules restrict it to the default branch, so every PR (dependabot's weekly action bumps included) was showing a spurious "had a problem deploying to github-pages" failure even though the deploy step itself never ran. Split into docs-build (runs on every push/PR, no environment) and docs-deploy (main-only, carries the environment) so PR runs never touch the github-pages environment at all. Co-Authored-By: Claude Sonnet 5 --- .github/workflows/ci.yml | 26 +++++++++++++++++--------- 1 file changed, 17 insertions(+), 9 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 8aa9b48ca..6744aa10f 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -100,16 +100,9 @@ jobs: with: files: ./coverage.xml - docs: + docs-build: needs: [test-core, test] runs-on: ubuntu-latest - permissions: - contents: read - pages: write - id-token: write - environment: - name: github-pages - url: ${{ steps.deploy.outputs.page_url }} steps: - uses: actions/checkout@v6 @@ -141,7 +134,22 @@ jobs: with: path: docs/build/html + # Separate job so the github-pages environment (and its deployment + # protection rules restricting it to main) is only ever touched on main — + # a job-level `environment:` triggers a deployment attempt as soon as the + # job starts, regardless of any step-level `if:`, so PR/dependabot runs + # would otherwise show a false "failed to deploy to github-pages". + docs-deploy: + needs: docs-build + if: github.ref == 'refs/heads/main' + runs-on: ubuntu-latest + permissions: + pages: write + id-token: write + environment: + name: github-pages + url: ${{ steps.deploy.outputs.page_url }} + steps: - name: Deploy to GitHub Pages id: deploy - if: github.ref == 'refs/heads/main' uses: actions/deploy-pages@v4 From 7d6bdc71d28e121c8abc6ad30e60c8d09ec254da Mon Sep 17 00:00:00 2001 From: Peter Corke Date: Fri, 3 Jul 2026 09:44:44 +1000 Subject: [PATCH 2/3] test: temporarily point rtb-data at GH main subdirectory MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit TEMPORARY, for CI validation only — revert before merging. See refactor/c-extensions@6dcfc624 for the same change and rationale. Co-Authored-By: Claude Sonnet 5 --- pyproject.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pyproject.toml b/pyproject.toml index 242382110..1133db38b 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -18,7 +18,7 @@ dependencies = [ "scipy", "matplotlib", "ansitable", - "rtb-data", + "rtb-data @ git+https://github.com/petercorke/robotics-toolbox-python.git@main#subdirectory=rtb-data", "progress", "typing_extensions", "colored>2.0.0", From 572e31e3d774165ac9318b7b3dbaed378254fcdb Mon Sep 17 00:00:00 2001 From: Peter Corke Date: Fri, 3 Jul 2026 10:21:56 +1000 Subject: [PATCH 3/3] Revert "test: temporarily point rtb-data at GH main subdirectory" This reverts commit 7d6bdc71d28e121c8abc6ad30e60c8d09ec254da. --- pyproject.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pyproject.toml b/pyproject.toml index 1133db38b..242382110 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -18,7 +18,7 @@ dependencies = [ "scipy", "matplotlib", "ansitable", - "rtb-data @ git+https://github.com/petercorke/robotics-toolbox-python.git@main#subdirectory=rtb-data", + "rtb-data", "progress", "typing_extensions", "colored>2.0.0",