Skip to content

Fixed the action views not rendering in EmbeddedData modal #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
4manasa merged 1 commit into from
May 22, 2026
Merged

Fixed the action views not rendering in EmbeddedData modal #479

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions ...ponents/src/lib/_components/template/simple-table-manual/simple-table-manual.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,12 +159,15 @@ export class SimpleTableManualComponent implements OnInit, OnDestroy {
referenceListStr: any;
bUseSeparateViewForEdit: any;
editView: any;
defaultActionId: any;
editActionId: any;
settingsSvgIcon$: string;

isInitialized = false;
targetClassLabel: string;
localizedVal = PCore.getLocaleUtils().getLocaleValue;
localeCategory = 'SimpleTable';
editType: any;
constructor(
private angularPConnect: AngularPConnectService,
public utils: Utils,
Expand Down Expand Up @@ -308,6 +311,10 @@ export class SimpleTableManualComponent implements OnInit, OnDestroy {
this.defaultView = editModeConfig ? editModeConfig.defaultView : viewForAddAndEditModal;
this.bUseSeparateViewForEdit = editModeConfig ? editModeConfig.useSeparateViewForEdit : useSeparateViewForEdit;
this.editView = editModeConfig ? editModeConfig.editView : viewForEditModal;
this.editType = editModeConfig?.editType;
this.defaultActionId = this.editType === 'action' ? editModeConfig?.defaultAction : undefined;
this.editActionId =
this.editType === 'action' && editModeConfig?.useSeparateActionForEdit ? editModeConfig?.editAction : editModeConfig?.defaultAction;
const primaryFieldsViewIndex = resolvedFields.findIndex(field => field.config.value === 'pyPrimaryFields');
// const showDeleteButton = !this.readOnlyMode && !hideDeleteRow;

Expand Down Expand Up @@ -958,17 +965,18 @@ export class SimpleTableManualComponent implements OnInit, OnDestroy {
}

addRecord() {
if (this.allowEditingInModal && this.defaultView) {
if (this.allowEditingInModal && (this.defaultView || this.defaultActionId)) {
this.pConn$
.getActionsApi()
// @ts-expect-error
.openEmbeddedDataModal(
this.defaultView,
this.pConn$ as any,
this.referenceListStr,
this.referenceList.length,
PCore.getConstants().RESOURCE_STATUS.CREATE,
this.targetClassLabel
this.targetClassLabel,
this.editType,
this.defaultActionId
);
} else {
this.pConn$.getListActions().insert({ classID: this.contextClass }, this.referenceList.length);
Expand Down
Loading