From 2166f8ec5dc91965a26e28871c9b201d00ff2412 Mon Sep 17 00:00:00 2001 From: Eric Olkowski Date: Fri, 10 Apr 2026 12:02:16 -0400 Subject: [PATCH 1/2] feat(Icons): updated cog icons to rh settings --- .../CodeEditor/examples/CodeEditor.md | 2 +- .../examples/CodeEditorConfigurationModal.tsx | 6 +++--- .../src/components/Icon/examples/Icon.md | 11 +++++++++- .../components/Icon/examples/IconBasic.tsx | 4 ++-- .../src/components/MenuToggle/MenuToggle.tsx | 4 ++-- .../MenuToggle/__tests__/MenuToggle.test.tsx | 4 ++-- .../__snapshots__/MenuToggle.test.tsx.snap | 20 ++++--------------- .../src/demos/CustomMenus/CustomMenus.md | 2 +- .../react-core/src/demos/DashboardHeader.tsx | 4 ++-- packages/react-core/src/demos/Masthead.md | 6 ++++-- packages/react-core/src/demos/Nav.md | 11 +++++++++- .../NotificationDrawer/NotificationDrawer.md | 3 +-- .../examples/NotificationDrawerBasic.tsx | 4 ++-- .../examples/NotificationDrawerGrouped.tsx | 4 ++-- packages/react-core/src/demos/Page.md | 2 +- packages/react-core/src/demos/RTL/RTL.md | 2 +- .../src/demos/RTL/examples/PaginatedTable.tsx | 4 ++-- packages/react-core/src/demos/Toolbar.md | 3 ++- .../Masthead/MastheadWithHorizontalNav.tsx | 4 ++-- ...stheadWithUtilitiesAndUserDropdownMenu.tsx | 4 ++-- .../src/demos/examples/Nav/NavFlyout.tsx | 4 ++-- .../src/demos/examples/Nav/NavHorizontal.tsx | 4 ++-- .../examples/Nav/NavHorizontalWithSubnav.tsx | 4 ++-- .../src/demos/examples/Nav/NavManual.tsx | 4 ++-- .../examples/Page/PageContextSelector.tsx | 4 ++-- .../Page/PageStickySectionBreadcrumb.tsx | 4 ++-- .../examples/Page/PageStickySectionGroup.tsx | 4 ++-- .../Page/PageStickySectionGroupAlternate.tsx | 4 ++-- .../react-table/src/demos/DashboardHeader.tsx | 4 ++-- packages/react-table/src/demos/Table.md | 2 +- 30 files changed, 75 insertions(+), 67 deletions(-) diff --git a/packages/react-code-editor/src/components/CodeEditor/examples/CodeEditor.md b/packages/react-code-editor/src/components/CodeEditor/examples/CodeEditor.md index 7fe074cf68c..d08e97eb061 100644 --- a/packages/react-code-editor/src/components/CodeEditor/examples/CodeEditor.md +++ b/packages/react-code-editor/src/components/CodeEditor/examples/CodeEditor.md @@ -9,7 +9,7 @@ Note: Code editor lives in its own package at [@patternfly/react-code-editor](ht import { Fragment, useState } from 'react'; import { CodeEditor, CodeEditorControl, Language } from '@patternfly/react-code-editor'; -import CogIcon from '@patternfly/react-icons/dist/esm/icons/cog-icon'; +import RhUiSettingsFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-settings-fill-icon'; import HashtagIcon from '@patternfly/react-icons/dist/esm/icons/hashtag-icon'; import MapIcon from '@patternfly/react-icons/dist/esm/icons/map-icon'; import MoonIcon from '@patternfly/react-icons/dist/esm/icons/moon-icon'; diff --git a/packages/react-code-editor/src/components/CodeEditor/examples/CodeEditorConfigurationModal.tsx b/packages/react-code-editor/src/components/CodeEditor/examples/CodeEditorConfigurationModal.tsx index 95b4e4e8516..85fc7fe4fd9 100644 --- a/packages/react-code-editor/src/components/CodeEditor/examples/CodeEditorConfigurationModal.tsx +++ b/packages/react-code-editor/src/components/CodeEditor/examples/CodeEditorConfigurationModal.tsx @@ -1,4 +1,4 @@ -import CogIcon from '@patternfly/react-icons/dist/esm/icons/cog-icon'; +import RhUiSettingsFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-settings-fill-icon'; import MapIcon from '@patternfly/react-icons/dist/esm/icons/map-icon'; import MoonIcon from '@patternfly/react-icons/dist/esm/icons/moon-icon'; import HashtagIcon from '@patternfly/react-icons/dist/esm/icons/hashtag-icon'; @@ -38,7 +38,7 @@ interface ConfigModalItemProps { } const ConfigModalItem: React.FunctionComponent = ({ - icon = , + icon = , description, title, id = `ConfigModalItem-${title.replace(/\s+/g, '-').toLowerCase()}`, @@ -77,7 +77,7 @@ interface ConfigModalSwitchProps extends Omit { } const ConfigModalSwitch: React.FunctionComponent = ({ - icon = , + icon = , description, title, id = `ConfigModalSwitch-${title.replace(/\s+/g, '-').toLowerCase()}`, diff --git a/packages/react-core/src/components/Icon/examples/Icon.md b/packages/react-core/src/components/Icon/examples/Icon.md index 19745f4c042..2212d1535b6 100644 --- a/packages/react-core/src/components/Icon/examples/Icon.md +++ b/packages/react-core/src/components/Icon/examples/Icon.md @@ -9,7 +9,7 @@ import { Fragment, useState } from 'react'; import LongArrowAltDownIcon from '@patternfly/react-icons/dist/esm/icons/long-arrow-alt-down-icon'; import RhMicronsCaretRightIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-right-icon'; import RhMicronsCaretDownIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-down-icon'; -import CogIcon from '@patternfly/react-icons/dist/esm/icons/cog-icon'; +import RhUiSettingsFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-settings-fill-icon'; import PlusCircleIcon from '@patternfly/react-icons/dist/esm/icons/plus-circle-icon'; import RhUiErrorFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-error-fill-icon'; import RhUiWarningFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-warning-fill-icon'; @@ -22,6 +22,7 @@ import RhUiNotificationFillIcon from '@patternfly/react-icons/dist/esm/icons/rh- ### Basic ```ts file="IconBasic.tsx" + ``` ### Standalone icon sizes @@ -29,6 +30,7 @@ import RhUiNotificationFillIcon from '@patternfly/react-icons/dist/esm/icons/rh- These are the standard options for sizing icons. ```ts file="StandaloneIconSizes.tsx" + ``` ### Body sizes @@ -36,6 +38,7 @@ These are the standard options for sizing icons. These size options are meant to make icons match the size of body text. ```ts file="BodyIconSizes.tsx" + ``` ### Heading sizes @@ -43,6 +46,7 @@ These size options are meant to make icons match the size of body text. These size options are meant to make icons match the size of heading text. ```ts file="HeadingIconSizes.tsx" + ``` ### Status colors @@ -50,6 +54,7 @@ These size options are meant to make icons match the size of heading text. The following example demonstrates the various status variants of an icon. Keep in mind that these icons are displayed out of a typical context, and that you should not rely on color alone to convey status to users. ```ts file="IconStatus.tsx" + ``` ### Sizing an icon within the icon container @@ -57,11 +62,13 @@ The following example demonstrates the various status variants of an icon. Keep Providing both size and iconSize properties allows the icon container to maintain a consistent size, even if the icon changes in size. ```ts file="IconContentSizes.tsx" + ``` ### Inline ```ts file="IconInline.tsx" + ``` ### In progress @@ -69,9 +76,11 @@ Providing both size and iconSize properties allows the icon container to maintai Passing the `isInProgress` property will swap the icon to a progress icon. By default this progress icon will be a `Spinner` but may be customized or overriden using the `progressIcon` property. ```ts file="IconProgress.tsx" + ``` ### Custom in progress icon ```ts file="IconCustomProgress.tsx" + ``` diff --git a/packages/react-core/src/components/Icon/examples/IconBasic.tsx b/packages/react-core/src/components/Icon/examples/IconBasic.tsx index 2b1ca39cefd..b99c2b7d171 100644 --- a/packages/react-core/src/components/Icon/examples/IconBasic.tsx +++ b/packages/react-core/src/components/Icon/examples/IconBasic.tsx @@ -3,7 +3,7 @@ import { Icon } from '@patternfly/react-core'; import LongArrowAltDownIcon from '@patternfly/react-icons/dist/esm/icons/long-arrow-alt-down-icon'; import RhMicronsCaretRightIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-right-icon'; import RhMicronsCaretDownIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-down-icon'; -import CogIcon from '@patternfly/react-icons/dist/esm/icons/cog-icon'; +import RhUiSettingsFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-settings-fill-icon'; export const IconBasic: React.FunctionComponent = () => ( @@ -17,7 +17,7 @@ export const IconBasic: React.FunctionComponent = () => ( {' '} - + ); diff --git a/packages/react-core/src/components/MenuToggle/MenuToggle.tsx b/packages/react-core/src/components/MenuToggle/MenuToggle.tsx index 565b478a928..cd465fde92f 100644 --- a/packages/react-core/src/components/MenuToggle/MenuToggle.tsx +++ b/packages/react-core/src/components/MenuToggle/MenuToggle.tsx @@ -3,7 +3,7 @@ import styles from '@patternfly/react-styles/css/components/MenuToggle/menu-togg import { css } from '@patternfly/react-styles'; import CaretDownIcon from '@patternfly/react-icons/dist/esm/icons/caret-down-icon'; import { BadgeProps } from '../Badge'; -import CogIcon from '@patternfly/react-icons/dist/esm/icons/cog-icon'; +import RhUiSettingsFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-settings-fill-icon'; import RhUiCheckCircleFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-check-circle-fill-icon'; import RhUiErrorFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-error-fill-icon'; import RhUiWarningFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-warning-fill-icon'; @@ -150,7 +150,7 @@ class MenuToggleBase extends Component { const content = ( <> {(icon || isSettings) && ( - {isSettings ? : icon} + {isSettings ? : icon} )} {isTypeahead ? children : children && {children}} {isValidElement(badge) && {badge}} diff --git a/packages/react-core/src/components/MenuToggle/__tests__/MenuToggle.test.tsx b/packages/react-core/src/components/MenuToggle/__tests__/MenuToggle.test.tsx index 2adbeda6b5e..4c5daa90c81 100644 --- a/packages/react-core/src/components/MenuToggle/__tests__/MenuToggle.test.tsx +++ b/packages/react-core/src/components/MenuToggle/__tests__/MenuToggle.test.tsx @@ -1,7 +1,7 @@ import { MenuToggle } from '../MenuToggle'; import { MenuToggleCheckbox } from '../MenuToggleCheckbox'; import { Badge } from '../../Badge'; -import CogIcon from '@patternfly/react-icons/dist/esm/icons/cog-icon'; +import RhUiSettingsFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-settings-fill-icon'; import EllipsisVIcon from '@patternfly/react-icons/dist/esm/icons/ellipsis-v-icon'; import userEvent from '@testing-library/user-event'; import { render, screen } from '@testing-library/react'; @@ -45,7 +45,7 @@ describe('Old Snapshot tests - remove when refactoring', () => { }); test('shows icon', () => { - const { asFragment } = render(}>Toggle); + const { asFragment } = render(}>Toggle); expect(asFragment()).toMatchSnapshot(); }); diff --git a/packages/react-core/src/components/MenuToggle/__tests__/__snapshots__/MenuToggle.test.tsx.snap b/packages/react-core/src/components/MenuToggle/__tests__/__snapshots__/MenuToggle.test.tsx.snap index f1f31132cba..5d40d191b6a 100644 --- a/packages/react-core/src/components/MenuToggle/__tests__/__snapshots__/MenuToggle.test.tsx.snap +++ b/packages/react-core/src/components/MenuToggle/__tests__/__snapshots__/MenuToggle.test.tsx.snap @@ -184,24 +184,12 @@ exports[`Old Snapshot tests - remove when refactoring shows icon 1`] = ` fill="currentColor" height="1em" role="img" + viewBox="0 0 32 32" width="1em" > - - - - - - + = ({ notificationBa const kebabDropdownItems = ( <> - Settings + Settings Help diff --git a/packages/react-core/src/demos/Masthead.md b/packages/react-core/src/demos/Masthead.md index 8aeb1319f05..2c9c89ac4ea 100644 --- a/packages/react-core/src/demos/Masthead.md +++ b/packages/react-core/src/demos/Masthead.md @@ -7,7 +7,7 @@ import { cloneElement, Fragment, useEffect, useRef, useState } from 'react'; import EllipsisVIcon from '@patternfly/react-icons/dist/esm/icons/ellipsis-v-icon'; import BarsIcon from '@patternfly/react-icons/dist/esm/icons/bars-icon'; import RhUiNotificationFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-notification-fill-icon'; -import CogIcon from '@patternfly/react-icons/dist/esm/icons/cog-icon'; +import RhUiSettingsFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-settings-fill-icon'; import HelpIcon from '@patternfly/react-icons/dist/esm/icons/help-icon'; import QuestionCircleIcon from '@patternfly/react-icons/dist/esm/icons/question-circle-icon'; import ThIcon from '@patternfly/react-icons/dist/esm/icons/th-icon'; @@ -24,7 +24,9 @@ Many mastheads contain utilities which collapse into a dropdown at smaller viewp ```ts file='./examples/Masthead/MastheadWithUtilitiesAndUserDropdownMenu.tsx' isFullscreen ``` + ### Horizontal nav + ```ts file='./examples/Masthead/MastheadWithHorizontalNav.tsx' isFullscreen -``` \ No newline at end of file +``` diff --git a/packages/react-core/src/demos/Nav.md b/packages/react-core/src/demos/Nav.md index a3973126bda..675382a0f8d 100644 --- a/packages/react-core/src/demos/Nav.md +++ b/packages/react-core/src/demos/Nav.md @@ -4,7 +4,7 @@ section: components --- import { Fragment, useState } from 'react'; -import CogIcon from '@patternfly/react-icons/dist/esm/icons/cog-icon'; +import RhUiSettingsFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-settings-fill-icon'; import HelpIcon from '@patternfly/react-icons/dist/esm/icons/help-icon'; import QuestionCircleIcon from '@patternfly/react-icons/dist/esm/icons/question-circle-icon'; import EllipsisVIcon from '@patternfly/react-icons/dist/esm/icons/ellipsis-v-icon'; @@ -20,44 +20,53 @@ import { DashboardHeader } from '@patternfly/react-core/dist/js/demos/DashboardH ### Default nav ```ts file="./examples/Nav/NavDefault.tsx" isFullscreen + ``` ### Grouped nav ```ts file="./examples/Nav/NavGrouped.tsx" isFullscreen + ``` ### Expandable nav ```ts file="./examples/Nav/NavExpandable.tsx" isFullscreen + ``` ### Horizontal nav ```ts file="./examples/Nav/NavHorizontal.tsx" isFullscreen + ``` ### Horizontal subnav ```ts file="./examples/Nav/NavWithSubnav.tsx" isFullscreen + ``` ### Horizontal nav with horizontal subnav ```ts file="./examples/Nav/NavHorizontalWithSubnav.tsx" isFullscreen + ``` ### Manual nav ```ts file="./examples/Nav/NavManual.tsx" isFullscreen + ``` ### Flyout nav ```ts file="./examples/Nav/NavFlyout.tsx" isFullscreen + ``` ### Drilldown nav ```ts isFullscreen file="./examples/Nav/NavDrilldown.tsx" + ``` diff --git a/packages/react-core/src/demos/NotificationDrawer/NotificationDrawer.md b/packages/react-core/src/demos/NotificationDrawer/NotificationDrawer.md index c39103ae5e6..ba43a1f5dce 100644 --- a/packages/react-core/src/demos/NotificationDrawer/NotificationDrawer.md +++ b/packages/react-core/src/demos/NotificationDrawer/NotificationDrawer.md @@ -6,7 +6,7 @@ section: components import { Fragment, useRef, useState } from 'react'; import RhUiNotificationFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-notification-fill-icon'; -import CogIcon from '@patternfly/react-icons/dist/esm/icons/cog-icon'; +import RhUiSettingsFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-settings-fill-icon'; import BarsIcon from '@patternfly/react-icons/dist/js/icons/bars-icon'; import HelpIcon from '@patternfly/react-icons/dist/esm/icons/help-icon'; import QuestionCircleIcon from '@patternfly/react-icons/dist/esm/icons/question-circle-icon'; @@ -18,7 +18,6 @@ import pfLogo from '@patternfly/react-core/src/demos/assets/PF-HorizontalLogo-Co ## Demos - Focus must be manually managed when the NotificationDrawer component is opened: - 1. Create a React `ref` and pass it into the NotificationDrawer component's `ref` attribute 2. Pass in a function to the `onNotificationDrawerExpand` prop of the Page component that will place focus on the first interact-able element inside the NotificationDrawer component via the previously created `ref` diff --git a/packages/react-core/src/demos/NotificationDrawer/examples/NotificationDrawerBasic.tsx b/packages/react-core/src/demos/NotificationDrawer/examples/NotificationDrawerBasic.tsx index a6736854e03..4009ffba283 100644 --- a/packages/react-core/src/demos/NotificationDrawer/examples/NotificationDrawerBasic.tsx +++ b/packages/react-core/src/demos/NotificationDrawer/examples/NotificationDrawerBasic.tsx @@ -45,7 +45,7 @@ import { ToolbarGroup, ToolbarContent } from '@patternfly/react-core'; -import CogIcon from '@patternfly/react-icons/dist/esm/icons/cog-icon'; +import RhUiSettingsFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-settings-fill-icon'; import HelpIcon from '@patternfly/react-icons/dist/esm/icons/help-icon'; import QuestionCircleIcon from '@patternfly/react-icons/dist/esm/icons/question-circle-icon'; import EllipsisVIcon from '@patternfly/react-icons/dist/esm/icons/ellipsis-v-icon'; @@ -157,7 +157,7 @@ export const NotificationDrawerBasic: React.FunctionComponent = () => { const kebabDropdownItems = ( <> - Settings + Settings Help diff --git a/packages/react-core/src/demos/NotificationDrawer/examples/NotificationDrawerGrouped.tsx b/packages/react-core/src/demos/NotificationDrawer/examples/NotificationDrawerGrouped.tsx index ece6abccc51..b17fea8206f 100644 --- a/packages/react-core/src/demos/NotificationDrawer/examples/NotificationDrawerGrouped.tsx +++ b/packages/react-core/src/demos/NotificationDrawer/examples/NotificationDrawerGrouped.tsx @@ -47,7 +47,7 @@ import { ToolbarGroup, ToolbarContent } from '@patternfly/react-core'; -import CogIcon from '@patternfly/react-icons/dist/esm/icons/cog-icon'; +import RhUiSettingsFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-settings-fill-icon'; import HelpIcon from '@patternfly/react-icons/dist/esm/icons/help-icon'; import SearchIcon from '@patternfly/react-icons/dist/esm/icons/search-icon'; import QuestionCircleIcon from '@patternfly/react-icons/dist/esm/icons/question-circle-icon'; @@ -207,7 +207,7 @@ export const NotificationDrawerGrouped: React.FunctionComponent = () => { const kebabDropdownItems = ( <> - Settings + Settings Help diff --git a/packages/react-core/src/demos/Page.md b/packages/react-core/src/demos/Page.md index 202cd65d792..780cad61f51 100644 --- a/packages/react-core/src/demos/Page.md +++ b/packages/react-core/src/demos/Page.md @@ -5,7 +5,7 @@ section: components import { useState, useRef, useEffect } from 'react'; import RhUiNotificationFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-notification-fill-icon'; -import CogIcon from '@patternfly/react-icons/dist/esm/icons/cog-icon'; +import RhUiSettingsFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-settings-fill-icon'; import HelpIcon from '@patternfly/react-icons/dist/esm/icons/help-icon'; import QuestionCircleIcon from '@patternfly/react-icons/dist/esm/icons/question-circle-icon'; import imgAvatar from '@patternfly/react-core/src/components/assets/avatarImg.svg'; diff --git a/packages/react-core/src/demos/RTL/RTL.md b/packages/react-core/src/demos/RTL/RTL.md index 37ddab0563d..658f61c3f34 100644 --- a/packages/react-core/src/demos/RTL/RTL.md +++ b/packages/react-core/src/demos/RTL/RTL.md @@ -12,7 +12,7 @@ import ClockIcon from '@patternfly/react-icons/dist/esm/icons/clock-icon'; import WalkingIcon from '@patternfly/react-icons/dist/esm/icons/walking-icon'; import pfLogo from '@patternfly/react-core/src/demos/assets/PF-HorizontalLogo-Color.svg'; import BarsIcon from '@patternfly/react-icons/dist/esm/icons/bars-icon'; -import CogIcon from '@patternfly/react-icons/dist/esm/icons/cog-icon'; +import RhUiSettingsFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-settings-fill-icon'; import QuestionCircleIcon from '@patternfly/react-icons/dist/esm/icons/question-circle-icon'; import HelpIcon from '@patternfly/react-icons/dist/esm/icons/help-icon'; import EllipsisVIcon from '@patternfly/react-icons/dist/esm/icons/ellipsis-v-icon'; diff --git a/packages/react-core/src/demos/RTL/examples/PaginatedTable.tsx b/packages/react-core/src/demos/RTL/examples/PaginatedTable.tsx index fa327c572c9..1144698b1e3 100644 --- a/packages/react-core/src/demos/RTL/examples/PaginatedTable.tsx +++ b/packages/react-core/src/demos/RTL/examples/PaginatedTable.tsx @@ -48,7 +48,7 @@ import ToolsIcon from '@patternfly/react-icons/dist/esm/icons/tools-icon'; import ClockIcon from '@patternfly/react-icons/dist/esm/icons/clock-icon'; import WalkingIcon from '@patternfly/react-icons/dist/esm/icons/walking-icon'; import pfLogo from '@patternfly/react-core/src/demos/assets/pf-logo.svg'; -import CogIcon from '@patternfly/react-icons/dist/esm/icons/cog-icon'; +import RhUiSettingsFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-settings-fill-icon'; import QuestionCircleIcon from '@patternfly/react-icons/dist/esm/icons/question-circle-icon'; import HelpIcon from '@patternfly/react-icons/dist/esm/icons/help-icon'; import EllipsisVIcon from '@patternfly/react-icons/dist/esm/icons/ellipsis-v-icon'; @@ -279,7 +279,7 @@ export const PaginatedTableAction: React.FunctionComponent = () => { const kebabDropdownItems = ( <> - }>{translation.kebabDropdown.settings} + }>{translation.kebabDropdown.settings} }>{translation.kebabDropdown.help} ); diff --git a/packages/react-core/src/demos/Toolbar.md b/packages/react-core/src/demos/Toolbar.md index 19560201610..c89670b8e5b 100644 --- a/packages/react-core/src/demos/Toolbar.md +++ b/packages/react-core/src/demos/Toolbar.md @@ -9,7 +9,7 @@ import PlayIcon from '@patternfly/react-icons/dist/esm/icons/play-icon'; import ExpandIcon from '@patternfly/react-icons/dist/esm/icons/expand-icon'; import ExternalLinkAltIcon from '@patternfly/react-icons/dist/esm/icons/external-link-alt-icon'; import DownloadIcon from '@patternfly/react-icons/dist/esm/icons/download-icon'; -import CogIcon from '@patternfly/react-icons/dist/esm/icons/cog-icon'; +import RhUiSettingsFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-settings-fill-icon'; import SearchIcon from '@patternfly/react-icons/dist/esm/icons/search-icon'; import TimesIcon from '@patternfly/react-icons/dist/esm/icons/times-icon'; import { DashboardWrapper } from '@patternfly/react-core/dist/js/demos/DashboardWrapper'; @@ -21,4 +21,5 @@ import { DashboardWrapper } from '@patternfly/react-core/dist/js/demos/Dashboard This is an example of toolbar usage in log viewer. ```ts file="examples/Toolbar/ConsoleLogViewerToolbar.tsx" isFullscreen + ``` diff --git a/packages/react-core/src/demos/examples/Masthead/MastheadWithHorizontalNav.tsx b/packages/react-core/src/demos/examples/Masthead/MastheadWithHorizontalNav.tsx index 671d14337bf..00e55594a1d 100644 --- a/packages/react-core/src/demos/examples/Masthead/MastheadWithHorizontalNav.tsx +++ b/packages/react-core/src/demos/examples/Masthead/MastheadWithHorizontalNav.tsx @@ -37,7 +37,7 @@ import { ToolbarItem } from '@patternfly/react-core'; import EllipsisVIcon from '@patternfly/react-icons/dist/esm/icons/ellipsis-v-icon'; -import CogIcon from '@patternfly/react-icons/dist/esm/icons/cog-icon'; +import RhUiSettingsFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-settings-fill-icon'; import HelpIcon from '@patternfly/react-icons/dist/esm/icons/help-icon'; import QuestionCircleIcon from '@patternfly/react-icons/dist/esm/icons/question-circle-icon'; import imgAvatar from '@patternfly/react-core/src/components/assets/avatarImg.svg'; @@ -129,7 +129,7 @@ export const MastheadWithHorizontalNav: React.FunctionComponent = () => { const kebabDropdownItems = ( <> - Settings + Settings Help diff --git a/packages/react-core/src/demos/examples/Masthead/MastheadWithUtilitiesAndUserDropdownMenu.tsx b/packages/react-core/src/demos/examples/Masthead/MastheadWithUtilitiesAndUserDropdownMenu.tsx index 8efdebdfb29..9dd25d9e917 100644 --- a/packages/react-core/src/demos/examples/Masthead/MastheadWithUtilitiesAndUserDropdownMenu.tsx +++ b/packages/react-core/src/demos/examples/Masthead/MastheadWithUtilitiesAndUserDropdownMenu.tsx @@ -50,7 +50,7 @@ import { Tooltip } from '@patternfly/react-core'; import EllipsisVIcon from '@patternfly/react-icons/dist/esm/icons/ellipsis-v-icon'; -import CogIcon from '@patternfly/react-icons/dist/esm/icons/cog-icon'; +import RhUiSettingsFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-settings-fill-icon'; import HelpIcon from '@patternfly/react-icons/dist/esm/icons/help-icon'; import ThIcon from '@patternfly/react-icons/dist/esm/icons/th-icon'; import QuestionCircleIcon from '@patternfly/react-icons/dist/esm/icons/question-circle-icon'; @@ -372,7 +372,7 @@ export const MastheadWithUtilitiesAndUserDropdownMenu: React.FunctionComponent = const kebabDropdownItems = ( <> - Settings + Settings Help diff --git a/packages/react-core/src/demos/examples/Nav/NavFlyout.tsx b/packages/react-core/src/demos/examples/Nav/NavFlyout.tsx index a9e2fcf9bba..47414a5ddbb 100644 --- a/packages/react-core/src/demos/examples/Nav/NavFlyout.tsx +++ b/packages/react-core/src/demos/examples/Nav/NavFlyout.tsx @@ -36,7 +36,7 @@ import { ToolbarGroup, ToolbarItem } from '@patternfly/react-core'; -import CogIcon from '@patternfly/react-icons/dist/esm/icons/cog-icon'; +import RhUiSettingsFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-settings-fill-icon'; import EllipsisVIcon from '@patternfly/react-icons/dist/esm/icons/ellipsis-v-icon'; import HelpIcon from '@patternfly/react-icons/dist/esm/icons/help-icon'; import QuestionCircleIcon from '@patternfly/react-icons/dist/esm/icons/question-circle-icon'; @@ -110,7 +110,7 @@ export const NavFlyout: React.FunctionComponent = () => { const kebabDropdownItems = ( <> - Settings + Settings Help diff --git a/packages/react-core/src/demos/examples/Nav/NavHorizontal.tsx b/packages/react-core/src/demos/examples/Nav/NavHorizontal.tsx index 59be2bedc2a..fc8976bac74 100644 --- a/packages/react-core/src/demos/examples/Nav/NavHorizontal.tsx +++ b/packages/react-core/src/demos/examples/Nav/NavHorizontal.tsx @@ -33,7 +33,7 @@ import { ToolbarGroup, ToolbarItem } from '@patternfly/react-core'; -import CogIcon from '@patternfly/react-icons/dist/esm/icons/cog-icon'; +import RhUiSettingsFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-settings-fill-icon'; import HelpIcon from '@patternfly/react-icons/dist/esm/icons/help-icon'; import QuestionCircleIcon from '@patternfly/react-icons/dist/esm/icons/question-circle-icon'; import EllipsisVIcon from '@patternfly/react-icons/dist/esm/icons/ellipsis-v-icon'; @@ -88,7 +88,7 @@ export const NavHorizontal: React.FunctionComponent = () => { const kebabDropdownItems = ( <> - Settings + Settings Help diff --git a/packages/react-core/src/demos/examples/Nav/NavHorizontalWithSubnav.tsx b/packages/react-core/src/demos/examples/Nav/NavHorizontalWithSubnav.tsx index 091f7c4f045..4b17005f1d3 100644 --- a/packages/react-core/src/demos/examples/Nav/NavHorizontalWithSubnav.tsx +++ b/packages/react-core/src/demos/examples/Nav/NavHorizontalWithSubnav.tsx @@ -36,7 +36,7 @@ import { ToolbarGroup, ToolbarItem } from '@patternfly/react-core'; -import CogIcon from '@patternfly/react-icons/dist/esm/icons/cog-icon'; +import RhUiSettingsFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-settings-fill-icon'; import HelpIcon from '@patternfly/react-icons/dist/esm/icons/help-icon'; import QuestionCircleIcon from '@patternfly/react-icons/dist/esm/icons/question-circle-icon'; import EllipsisVIcon from '@patternfly/react-icons/dist/esm/icons/ellipsis-v-icon'; @@ -107,7 +107,7 @@ export const NavHorizontalWithSubnav: React.FunctionComponent = () => { const kebabDropdownItems = ( <> - Settings + Settings Help diff --git a/packages/react-core/src/demos/examples/Nav/NavManual.tsx b/packages/react-core/src/demos/examples/Nav/NavManual.tsx index 6a429f92a67..d3a232e8342 100644 --- a/packages/react-core/src/demos/examples/Nav/NavManual.tsx +++ b/packages/react-core/src/demos/examples/Nav/NavManual.tsx @@ -37,7 +37,7 @@ import { ToolbarGroup, ToolbarItem } from '@patternfly/react-core'; -import CogIcon from '@patternfly/react-icons/dist/esm/icons/cog-icon'; +import RhUiSettingsFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-settings-fill-icon'; import HelpIcon from '@patternfly/react-icons/dist/esm/icons/help-icon'; import QuestionCircleIcon from '@patternfly/react-icons/dist/esm/icons/question-circle-icon'; import EllipsisVIcon from '@patternfly/react-icons/dist/esm/icons/ellipsis-v-icon'; @@ -104,7 +104,7 @@ export const NavManual: React.FunctionComponent = () => { const kebabDropdownItems = ( <> - Settings + Settings Help diff --git a/packages/react-core/src/demos/examples/Page/PageContextSelector.tsx b/packages/react-core/src/demos/examples/Page/PageContextSelector.tsx index ad6d874eac9..d06d0e7d720 100644 --- a/packages/react-core/src/demos/examples/Page/PageContextSelector.tsx +++ b/packages/react-core/src/demos/examples/Page/PageContextSelector.tsx @@ -40,7 +40,7 @@ import { ToolbarGroup, ToolbarItem } from '@patternfly/react-core'; -import CogIcon from '@patternfly/react-icons/dist/esm/icons/cog-icon'; +import RhUiSettingsFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-settings-fill-icon'; import HelpIcon from '@patternfly/react-icons/dist/esm/icons/help-icon'; import QuestionCircleIcon from '@patternfly/react-icons/dist/esm/icons/question-circle-icon'; import EllipsisVIcon from '@patternfly/react-icons/dist/esm/icons/ellipsis-v-icon'; @@ -114,7 +114,7 @@ export const PageStickySectionBreadcrumb: React.FunctionComponent = () => { const kebabDropdownItems = ( <> - Settings + Settings Help diff --git a/packages/react-core/src/demos/examples/Page/PageStickySectionBreadcrumb.tsx b/packages/react-core/src/demos/examples/Page/PageStickySectionBreadcrumb.tsx index 3a25dd547b5..7ddc9699568 100644 --- a/packages/react-core/src/demos/examples/Page/PageStickySectionBreadcrumb.tsx +++ b/packages/react-core/src/demos/examples/Page/PageStickySectionBreadcrumb.tsx @@ -40,7 +40,7 @@ import { ToolbarGroup, ToolbarItem } from '@patternfly/react-core'; -import CogIcon from '@patternfly/react-icons/dist/esm/icons/cog-icon'; +import RhUiSettingsFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-settings-fill-icon'; import HelpIcon from '@patternfly/react-icons/dist/esm/icons/help-icon'; import QuestionCircleIcon from '@patternfly/react-icons/dist/esm/icons/question-circle-icon'; import EllipsisVIcon from '@patternfly/react-icons/dist/esm/icons/ellipsis-v-icon'; @@ -100,7 +100,7 @@ export const PageStickySectionBreadcrumb: React.FunctionComponent = () => { const kebabDropdownItems = ( <> - Settings + Settings Help diff --git a/packages/react-core/src/demos/examples/Page/PageStickySectionGroup.tsx b/packages/react-core/src/demos/examples/Page/PageStickySectionGroup.tsx index c54a403de8e..d75b6df8432 100644 --- a/packages/react-core/src/demos/examples/Page/PageStickySectionGroup.tsx +++ b/packages/react-core/src/demos/examples/Page/PageStickySectionGroup.tsx @@ -40,7 +40,7 @@ import { ToolbarGroup, ToolbarItem } from '@patternfly/react-core'; -import CogIcon from '@patternfly/react-icons/dist/esm/icons/cog-icon'; +import RhUiSettingsFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-settings-fill-icon'; import HelpIcon from '@patternfly/react-icons/dist/esm/icons/help-icon'; import QuestionCircleIcon from '@patternfly/react-icons/dist/esm/icons/question-circle-icon'; import EllipsisVIcon from '@patternfly/react-icons/dist/esm/icons/ellipsis-v-icon'; @@ -100,7 +100,7 @@ export const PageStickySectionGroup: React.FunctionComponent = () => { const kebabDropdownItems = ( <> - Settings + Settings Help diff --git a/packages/react-core/src/demos/examples/Page/PageStickySectionGroupAlternate.tsx b/packages/react-core/src/demos/examples/Page/PageStickySectionGroupAlternate.tsx index 7ed65f2ccad..1873b6f3e44 100644 --- a/packages/react-core/src/demos/examples/Page/PageStickySectionGroupAlternate.tsx +++ b/packages/react-core/src/demos/examples/Page/PageStickySectionGroupAlternate.tsx @@ -42,7 +42,7 @@ import { ToolbarGroup, ToolbarItem } from '@patternfly/react-core'; -import CogIcon from '@patternfly/react-icons/dist/esm/icons/cog-icon'; +import RhUiSettingsFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-settings-fill-icon'; import HelpIcon from '@patternfly/react-icons/dist/esm/icons/help-icon'; import QuestionCircleIcon from '@patternfly/react-icons/dist/esm/icons/question-circle-icon'; import EllipsisVIcon from '@patternfly/react-icons/dist/esm/icons/ellipsis-v-icon'; @@ -92,7 +92,7 @@ export const PageStickySectionGroupAlternate: React.FunctionComponent = () => { const kebabDropdownItems = ( <> - Settings + Settings Help diff --git a/packages/react-table/src/demos/DashboardHeader.tsx b/packages/react-table/src/demos/DashboardHeader.tsx index 1798c9cbb99..33b2fc1abf7 100644 --- a/packages/react-table/src/demos/DashboardHeader.tsx +++ b/packages/react-table/src/demos/DashboardHeader.tsx @@ -23,7 +23,7 @@ import { ToolbarItem, PageToggleButton } from '@patternfly/react-core'; -import CogIcon from '@patternfly/react-icons/dist/esm/icons/cog-icon'; +import RhUiSettingsFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-settings-fill-icon'; import HelpIcon from '@patternfly/react-icons/dist/esm/icons/help-icon'; import QuestionCircleIcon from '@patternfly/react-icons/dist/esm/icons/question-circle-icon'; import EllipsisVIcon from '@patternfly/react-icons/dist/esm/icons/ellipsis-v-icon'; @@ -87,7 +87,7 @@ export const DashboardHeader: React.FC = ({ notificationBa const kebabDropdownItems = ( <> - Settings + Settings Help diff --git a/packages/react-table/src/demos/Table.md b/packages/react-table/src/demos/Table.md index 282cb1de9db..15ceffc71b2 100644 --- a/packages/react-table/src/demos/Table.md +++ b/packages/react-table/src/demos/Table.md @@ -59,7 +59,7 @@ import SortAmountDownIcon from '@patternfly/react-icons/dist/esm/icons/sort-amou import SearchIcon from '@patternfly/react-icons/dist/esm/icons/search-icon'; import SyncIcon from '@patternfly/react-icons/dist/esm/icons/sync-icon'; import RhUiErrorFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-error-fill-icon'; -import CogIcon from '@patternfly/react-icons/dist/esm/icons/cog-icon'; +import RhUiSettingsFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-settings-fill-icon'; import HelpIcon from '@patternfly/react-icons/dist/esm/icons/help-icon'; import QuestionCircleIcon from '@patternfly/react-icons/dist/esm/icons/question-circle-icon'; import RhMicronsCaretDownIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-down-icon'; From ead65324d2060f455642e693aab80259c3f1fa78 Mon Sep 17 00:00:00 2001 From: Eric Olkowski Date: Fri, 10 Apr 2026 14:23:58 -0400 Subject: [PATCH 2/2] Updated button cog icon --- packages/react-core/src/components/Button/Button.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/react-core/src/components/Button/Button.tsx b/packages/react-core/src/components/Button/Button.tsx index 86b40f66826..2c6a28da139 100644 --- a/packages/react-core/src/components/Button/Button.tsx +++ b/packages/react-core/src/components/Button/Button.tsx @@ -6,7 +6,7 @@ import { useOUIAProps, OUIAProps } from '../../helpers/OUIA/ouia'; import { Badge } from '../Badge'; import StarIcon from '@patternfly/react-icons/dist/esm/icons/star-icon'; import OutlinedStarIcon from '@patternfly/react-icons/dist/esm/icons/outlined-star-icon'; -import CogIcon from '@patternfly/react-icons/dist/esm/icons/cog-icon'; +import RhUiSettingsFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-settings-fill-icon'; import { hamburgerIcon } from './hamburgerIcon'; export enum ButtonVariant { @@ -215,7 +215,7 @@ const ButtonBase: React.FunctionComponent = ({ } if (isSettings) { - iconContent = ; + iconContent = ; } if (isHamburger) { iconContent = hamburgerIcon;