From 94aa00b0d51894192745e2cc1b3868ea4abe8b30 Mon Sep 17 00:00:00 2001 From: Jose Palomares Date: Thu, 13 Aug 2026 16:31:43 +0200 Subject: [PATCH 1/6] feat: INF-4136 make Deployment progressDeadlineSeconds configurable --- parcellab/common/Chart.yaml | 2 +- parcellab/common/templates/_deployment.tpl | 3 +++ parcellab/monolith/Chart.yaml | 2 +- parcellab/monolith/values.yaml | 7 +++++++ 4 files changed, 12 insertions(+), 2 deletions(-) diff --git a/parcellab/common/Chart.yaml b/parcellab/common/Chart.yaml index a4f5e85a..949c90a7 100644 --- a/parcellab/common/Chart.yaml +++ b/parcellab/common/Chart.yaml @@ -2,7 +2,7 @@ apiVersion: v2 name: common description: A Helm chart library for parcelLab charts type: library -version: 1.3.12 +version: 1.3.13 maintainers: - name: parcelLab email: engineering@parcellab.com diff --git a/parcellab/common/templates/_deployment.tpl b/parcellab/common/templates/_deployment.tpl index a34b5ac5..f5a09b61 100644 --- a/parcellab/common/templates/_deployment.tpl +++ b/parcellab/common/templates/_deployment.tpl @@ -40,6 +40,9 @@ spec: {{- toYaml .Values.strategy | nindent 4 }} {{- end }} revisionHistoryLimit: {{ .Values.revisionHistoryLimit }} + {{- with (default .Values.progressDeadlineSeconds $service.progressDeadlineSeconds) }} + progressDeadlineSeconds: {{ . }} + {{- end }} selector: matchLabels: {{- include "common.selectors" $componentValues | nindent 6 }} diff --git a/parcellab/monolith/Chart.yaml b/parcellab/monolith/Chart.yaml index a0d00947..58a30da7 100644 --- a/parcellab/monolith/Chart.yaml +++ b/parcellab/monolith/Chart.yaml @@ -1,7 +1,7 @@ apiVersion: v2 name: monolith description: Application that may define multiple services and cronjobs -version: 0.6.2 +version: 0.6.3 dependencies: - name: common version: "*" diff --git a/parcellab/monolith/values.yaml b/parcellab/monolith/values.yaml index d0a0b8c8..412e3f87 100644 --- a/parcellab/monolith/values.yaml +++ b/parcellab/monolith/values.yaml @@ -523,6 +523,13 @@ podLabels: {} deploymentAnnotations: {} +# Seconds the Deployment controller waits for a rollout to make progress +# before marking it ProgressDeadlineExceeded (surfaces as ArgoCD "Degraded"). +# Defaults to the Kubernetes default of 600s; raise it for workloads whose +# pods legitimately take longer than 10m to become Ready (e.g. gated by a +# startupProbe with a large failureThreshold). +progressDeadlineSeconds: 600 + replicaCount: 1 # disables setting replica count in case of autoscaling enabled disableReplicaCount: false From 15e6125b43c761cb337823107a50f43a2463d152 Mon Sep 17 00:00:00 2001 From: Jose Palomares Date: Thu, 13 Aug 2026 16:37:58 +0200 Subject: [PATCH 2/6] feat: INF-4136 document progressDeadlineSeconds in microservice and worker-group too --- parcellab/microservice/Chart.yaml | 2 +- parcellab/microservice/values.yaml | 7 +++++++ parcellab/worker-group/Chart.yaml | 2 +- parcellab/worker-group/values.yaml | 7 +++++++ 4 files changed, 16 insertions(+), 2 deletions(-) diff --git a/parcellab/microservice/Chart.yaml b/parcellab/microservice/Chart.yaml index 590cfc56..65fcfbb2 100644 --- a/parcellab/microservice/Chart.yaml +++ b/parcellab/microservice/Chart.yaml @@ -1,7 +1,7 @@ apiVersion: v2 name: microservice description: Simple microservice -version: 0.6.2 +version: 0.6.3 dependencies: - name: common version: "*" diff --git a/parcellab/microservice/values.yaml b/parcellab/microservice/values.yaml index c95438d8..2c54cb1e 100644 --- a/parcellab/microservice/values.yaml +++ b/parcellab/microservice/values.yaml @@ -370,6 +370,13 @@ podAnnotations: {} # opting into an EKS Fargate profile: { parcellab.dev/compute: fargate }. podLabels: {} +# Seconds the Deployment controller waits for a rollout to make progress +# before marking it ProgressDeadlineExceeded (surfaces as ArgoCD "Degraded"). +# Defaults to the Kubernetes default of 600s; raise it for workloads whose +# pods legitimately take longer than 10m to become Ready (e.g. gated by a +# startupProbe with a large failureThreshold). +progressDeadlineSeconds: 600 + replicaCount: 1 strategy: diff --git a/parcellab/worker-group/Chart.yaml b/parcellab/worker-group/Chart.yaml index 98e0333c..58328cef 100644 --- a/parcellab/worker-group/Chart.yaml +++ b/parcellab/worker-group/Chart.yaml @@ -1,7 +1,7 @@ apiVersion: v2 name: worker-group description: Set of workers that do not expose a service -version: 0.3.6 +version: 0.3.7 dependencies: - name: common version: "*" diff --git a/parcellab/worker-group/values.yaml b/parcellab/worker-group/values.yaml index 38be6acb..c650c941 100644 --- a/parcellab/worker-group/values.yaml +++ b/parcellab/worker-group/values.yaml @@ -171,6 +171,13 @@ podAnnotations: {} # opting into an EKS Fargate profile: { parcellab.dev/compute: fargate }. podLabels: {} +# Seconds the Deployment controller waits for a rollout to make progress +# before marking it ProgressDeadlineExceeded (surfaces as ArgoCD "Degraded"). +# Defaults to the Kubernetes default of 600s; raise it for workloads whose +# pods legitimately take longer than 10m to become Ready (e.g. gated by a +# startupProbe with a large failureThreshold). +progressDeadlineSeconds: 600 + replicaCount: 1 disableReplicaCount: false From 03d7b6f3985a7cb68e3b03acb0f8585929fa7b52 Mon Sep 17 00:00:00 2001 From: Jose Palomares Date: Thu, 13 Aug 2026 17:26:39 +0200 Subject: [PATCH 3/6] docs: INF-4136 document per-item override and null behavior for progressDeadlineSeconds --- parcellab/monolith/values.yaml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/parcellab/monolith/values.yaml b/parcellab/monolith/values.yaml index 412e3f87..ac06ebb7 100644 --- a/parcellab/monolith/values.yaml +++ b/parcellab/monolith/values.yaml @@ -46,6 +46,7 @@ extraServices: # httpGet: # path: / # port: http + # progressDeadlineSeconds: 600 # resources: # limits: # cpu: 100m @@ -324,6 +325,7 @@ workers: [] # httpGet: # path: / # port: http +# progressDeadlineSeconds: 600 # containerEnv: # - name: MY_ENV_VAR # value: "myvalue" @@ -527,7 +529,9 @@ deploymentAnnotations: {} # before marking it ProgressDeadlineExceeded (surfaces as ArgoCD "Degraded"). # Defaults to the Kubernetes default of 600s; raise it for workloads whose # pods legitimately take longer than 10m to become Ready (e.g. gated by a -# startupProbe with a large failureThreshold). +# startupProbe with a large failureThreshold). Can be overridden per-item on +# an extraServices/workers entry (see below); set to `null` to omit the field +# entirely and let Kubernetes apply its own default instead of this chart's. progressDeadlineSeconds: 600 replicaCount: 1 From b36512551097d3d8be417caf0f70bb71c033c1ca Mon Sep 17 00:00:00 2001 From: Jose Palomares Date: Fri, 14 Aug 2026 11:25:45 +0200 Subject: [PATCH 4/6] refactor: INF-4136 centralize progressDeadlineSeconds default in the shared template --- parcellab/common/templates/_deployment.tpl | 4 +--- parcellab/microservice/values.yaml | 4 ---- parcellab/monolith/values.yaml | 6 ------ parcellab/worker-group/values.yaml | 4 ---- 4 files changed, 1 insertion(+), 17 deletions(-) diff --git a/parcellab/common/templates/_deployment.tpl b/parcellab/common/templates/_deployment.tpl index f5a09b61..e6bcc536 100644 --- a/parcellab/common/templates/_deployment.tpl +++ b/parcellab/common/templates/_deployment.tpl @@ -40,9 +40,7 @@ spec: {{- toYaml .Values.strategy | nindent 4 }} {{- end }} revisionHistoryLimit: {{ .Values.revisionHistoryLimit }} - {{- with (default .Values.progressDeadlineSeconds $service.progressDeadlineSeconds) }} - progressDeadlineSeconds: {{ . }} - {{- end }} + progressDeadlineSeconds: {{ default 600 (default .Values.progressDeadlineSeconds $service.progressDeadlineSeconds) }} selector: matchLabels: {{- include "common.selectors" $componentValues | nindent 6 }} diff --git a/parcellab/microservice/values.yaml b/parcellab/microservice/values.yaml index 2c54cb1e..84b5aec2 100644 --- a/parcellab/microservice/values.yaml +++ b/parcellab/microservice/values.yaml @@ -372,10 +372,6 @@ podLabels: {} # Seconds the Deployment controller waits for a rollout to make progress # before marking it ProgressDeadlineExceeded (surfaces as ArgoCD "Degraded"). -# Defaults to the Kubernetes default of 600s; raise it for workloads whose -# pods legitimately take longer than 10m to become Ready (e.g. gated by a -# startupProbe with a large failureThreshold). -progressDeadlineSeconds: 600 replicaCount: 1 diff --git a/parcellab/monolith/values.yaml b/parcellab/monolith/values.yaml index ac06ebb7..79b59a95 100644 --- a/parcellab/monolith/values.yaml +++ b/parcellab/monolith/values.yaml @@ -527,12 +527,6 @@ deploymentAnnotations: {} # Seconds the Deployment controller waits for a rollout to make progress # before marking it ProgressDeadlineExceeded (surfaces as ArgoCD "Degraded"). -# Defaults to the Kubernetes default of 600s; raise it for workloads whose -# pods legitimately take longer than 10m to become Ready (e.g. gated by a -# startupProbe with a large failureThreshold). Can be overridden per-item on -# an extraServices/workers entry (see below); set to `null` to omit the field -# entirely and let Kubernetes apply its own default instead of this chart's. -progressDeadlineSeconds: 600 replicaCount: 1 # disables setting replica count in case of autoscaling enabled diff --git a/parcellab/worker-group/values.yaml b/parcellab/worker-group/values.yaml index c650c941..43ec5d62 100644 --- a/parcellab/worker-group/values.yaml +++ b/parcellab/worker-group/values.yaml @@ -173,10 +173,6 @@ podLabels: {} # Seconds the Deployment controller waits for a rollout to make progress # before marking it ProgressDeadlineExceeded (surfaces as ArgoCD "Degraded"). -# Defaults to the Kubernetes default of 600s; raise it for workloads whose -# pods legitimately take longer than 10m to become Ready (e.g. gated by a -# startupProbe with a large failureThreshold). -progressDeadlineSeconds: 600 replicaCount: 1 disableReplicaCount: false From 9a4681448c35dcc01c2c9ac67e677a886f210cac Mon Sep 17 00:00:00 2001 From: Jose Palomares Date: Fri, 14 Aug 2026 11:27:24 +0200 Subject: [PATCH 5/6] docs: INF-4136 drop dangling progressDeadlineSeconds comment with no example value --- parcellab/microservice/values.yaml | 3 --- parcellab/monolith/values.yaml | 3 --- parcellab/worker-group/values.yaml | 3 --- 3 files changed, 9 deletions(-) diff --git a/parcellab/microservice/values.yaml b/parcellab/microservice/values.yaml index 84b5aec2..c95438d8 100644 --- a/parcellab/microservice/values.yaml +++ b/parcellab/microservice/values.yaml @@ -370,9 +370,6 @@ podAnnotations: {} # opting into an EKS Fargate profile: { parcellab.dev/compute: fargate }. podLabels: {} -# Seconds the Deployment controller waits for a rollout to make progress -# before marking it ProgressDeadlineExceeded (surfaces as ArgoCD "Degraded"). - replicaCount: 1 strategy: diff --git a/parcellab/monolith/values.yaml b/parcellab/monolith/values.yaml index 79b59a95..c2eadc74 100644 --- a/parcellab/monolith/values.yaml +++ b/parcellab/monolith/values.yaml @@ -525,9 +525,6 @@ podLabels: {} deploymentAnnotations: {} -# Seconds the Deployment controller waits for a rollout to make progress -# before marking it ProgressDeadlineExceeded (surfaces as ArgoCD "Degraded"). - replicaCount: 1 # disables setting replica count in case of autoscaling enabled disableReplicaCount: false diff --git a/parcellab/worker-group/values.yaml b/parcellab/worker-group/values.yaml index 43ec5d62..38be6acb 100644 --- a/parcellab/worker-group/values.yaml +++ b/parcellab/worker-group/values.yaml @@ -171,9 +171,6 @@ podAnnotations: {} # opting into an EKS Fargate profile: { parcellab.dev/compute: fargate }. podLabels: {} -# Seconds the Deployment controller waits for a rollout to make progress -# before marking it ProgressDeadlineExceeded (surfaces as ArgoCD "Degraded"). - replicaCount: 1 disableReplicaCount: false From eb8f87e1040ced72fe53251d75bf3a0c2950ca34 Mon Sep 17 00:00:00 2001 From: Jose Palomares Date: Fri, 14 Aug 2026 11:30:47 +0200 Subject: [PATCH 6/6] docs: INF-4136 drop progressDeadlineSeconds from example blocks too --- parcellab/monolith/values.yaml | 2 -- 1 file changed, 2 deletions(-) diff --git a/parcellab/monolith/values.yaml b/parcellab/monolith/values.yaml index c2eadc74..d0a0b8c8 100644 --- a/parcellab/monolith/values.yaml +++ b/parcellab/monolith/values.yaml @@ -46,7 +46,6 @@ extraServices: # httpGet: # path: / # port: http - # progressDeadlineSeconds: 600 # resources: # limits: # cpu: 100m @@ -325,7 +324,6 @@ workers: [] # httpGet: # path: / # port: http -# progressDeadlineSeconds: 600 # containerEnv: # - name: MY_ENV_VAR # value: "myvalue"