Summary
While validating the fix for #1929 (bare super(...) extraction), I noticed tests/benchmarks/resolution/fixtures/typescript/hierarchy.ts's constructor-instantiation call sites resolve to both the class node and the class's .constructor method node:
makeCircle@hierarchy.ts -> Circle@hierarchy.ts (documented in expected-edges.json)
makeCircle@hierarchy.ts -> Circle.constructor@hierarchy.ts (NOT documented)
makeEllipse@hierarchy.ts -> Ellipse.constructor@hierarchy.ts (NOT documented)
makeRectangle@hierarchy.ts -> Rectangle.constructor@hierarchy.ts (NOT documented)
The X.constructor edges come from the existing constructor-call attribution feature (#1892) — they're correct, pre-existing behavior, unrelated to #1929's bare-super(...) fix. They just aren't listed in expected-edges.json, so the benchmark's recall metric doesn't credit them and precision headroom is slightly eaten by "extra" resolved edges the test doesn't know about.
Suggested fix
Add the missing X.constructor target entries (mode: constructor) alongside the existing X class-node entries in tests/benchmarks/resolution/fixtures/typescript/expected-edges.json, and audit other language fixtures for the same gap if the #1892 attribution applies there too.
Found opportunistically while working on #1929 — filed separately per this repo's scope-discipline convention rather than folded into that PR.
Summary
While validating the fix for #1929 (bare
super(...)extraction), I noticedtests/benchmarks/resolution/fixtures/typescript/hierarchy.ts's constructor-instantiation call sites resolve to both the class node and the class's.constructormethod node:The
X.constructoredges come from the existing constructor-call attribution feature (#1892) — they're correct, pre-existing behavior, unrelated to #1929's bare-super(...)fix. They just aren't listed inexpected-edges.json, so the benchmark's recall metric doesn't credit them and precision headroom is slightly eaten by "extra" resolved edges the test doesn't know about.Suggested fix
Add the missing
X.constructortarget entries (mode:constructor) alongside the existingXclass-node entries intests/benchmarks/resolution/fixtures/typescript/expected-edges.json, and audit other language fixtures for the same gap if the #1892 attribution applies there too.Found opportunistically while working on #1929 — filed separately per this repo's scope-discipline convention rather than folded into that PR.