Skip to content

Commit ba7a7fa

Browse files
committed
wip
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
1 parent bc29dc1 commit ba7a7fa

3 files changed

Lines changed: 42 additions & 10 deletions

File tree

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/ResourceOperations.java

Lines changed: 34 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ public <R extends HasMetadata> R serverSideApply(
145145
* @return updated resource
146146
* @param <R> resource type
147147
*/
148-
public <R extends HasMetadata> R serverSideApplyStatus(R resource) {
148+
public <R extends HasMetadata> R serverSideApplyStatus(R resource, Options options) {
149149
return resourcePatch(
150150
resource,
151151
r ->
@@ -158,7 +158,12 @@ public <R extends HasMetadata> R serverSideApplyStatus(R resource) {
158158
.withForce(true)
159159
.withFieldManager(context.getControllerConfiguration().fieldManager())
160160
.withPatchType(PatchType.SERVER_SIDE_APPLY)
161-
.build()));
161+
.build()),
162+
options);
163+
}
164+
165+
public <R extends HasMetadata> R serverSideApplyStatus(R resource) {
166+
return serverSideApplyStatus(resource, null);
162167
}
163168

164169
/**
@@ -246,7 +251,7 @@ public <R extends HasMetadata> R update(R resource, Options options) {
246251

247252
public <R extends HasMetadata> R update(
248253
R resource, InformerEventSource<R, P> informerEventSource) {
249-
return update(resource, informerEventSource, null);
254+
return update(resource, informerEventSource, new Options(true));
250255
}
251256

252257
/**
@@ -334,7 +339,8 @@ public <R extends HasMetadata> R create(
334339
* @param <R> resource type
335340
*/
336341
public <R extends HasMetadata> R updateStatus(R resource) {
337-
return resourcePatch(resource, r -> context.getClient().resource(r).updateStatus());
342+
return resourcePatch(
343+
resource, r -> context.getClient().resource(r).updateStatus(), new Options(true));
338344
}
339345

340346
/**
@@ -397,7 +403,13 @@ public P updatePrimaryStatus(P resource) {
397403
* @param <R> resource type
398404
*/
399405
public <R extends HasMetadata> R jsonPatch(R resource, UnaryOperator<R> unaryOperator) {
400-
return resourcePatch(resource, r -> context.getClient().resource(r).edit(unaryOperator));
406+
return jsonPatch(resource, unaryOperator, null);
407+
}
408+
409+
public <R extends HasMetadata> R jsonPatch(
410+
R resource, UnaryOperator<R> unaryOperator, Options options) {
411+
return resourcePatch(
412+
resource, r -> context.getClient().resource(r).edit(unaryOperator), options);
401413
}
402414

403415
/**
@@ -417,8 +429,14 @@ public <R extends HasMetadata> R jsonPatch(R resource, UnaryOperator<R> unaryOpe
417429
* @return updated resource
418430
* @param <R> resource type
419431
*/
432+
public <R extends HasMetadata> R jsonPatchStatus(
433+
R resource, UnaryOperator<R> unaryOperator, Options options) {
434+
return resourcePatch(
435+
resource, r -> context.getClient().resource(r).editStatus(unaryOperator), options);
436+
}
437+
420438
public <R extends HasMetadata> R jsonPatchStatus(R resource, UnaryOperator<R> unaryOperator) {
421-
return resourcePatch(resource, r -> context.getClient().resource(r).editStatus(unaryOperator));
439+
return jsonPatchStatus(resource, unaryOperator, null);
422440
}
423441

424442
/**
@@ -482,7 +500,11 @@ public P jsonPatchPrimaryStatus(P resource, UnaryOperator<P> unaryOperator) {
482500
* @param <R> resource type
483501
*/
484502
public <R extends HasMetadata> R jsonMergePatch(R resource) {
485-
return resourcePatch(resource, r -> context.getClient().resource(r).patch());
503+
return jsonMergePatch(resource, null);
504+
}
505+
506+
public <R extends HasMetadata> R jsonMergePatch(R resource, Options options) {
507+
return resourcePatch(resource, r -> context.getClient().resource(r).patch(), options);
486508
}
487509

488510
/**
@@ -501,7 +523,11 @@ public <R extends HasMetadata> R jsonMergePatch(R resource) {
501523
* @param <R> resource type
502524
*/
503525
public <R extends HasMetadata> R jsonMergePatchStatus(R resource) {
504-
return resourcePatch(resource, r -> context.getClient().resource(r).patchStatus());
526+
return jsonMergePatchStatus(resource, null);
527+
}
528+
529+
public <R extends HasMetadata> R jsonMergePatchStatus(R resource, Options options) {
530+
return resourcePatch(resource, r -> context.getClient().resource(r).patchStatus(), options);
505531
}
506532

507533
/**

operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/changenamespace/ChangeNamespaceTestReconciler.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,9 @@ public UpdateControl<ChangeNamespaceTestCustomResource> reconcile(
5353
ChangeNamespaceTestCustomResource primary,
5454
Context<ChangeNamespaceTestCustomResource> context) {
5555

56-
context.resourceOperations().serverSideApply(configMap(primary));
56+
context
57+
.resourceOperations()
58+
.serverSideApply(configMap(primary), new ResourceOperations.Options(true));
5759

5860
if (primary.getStatus() == null) {
5961
primary.setStatus(new ChangeNamespaceTestCustomResourceStatus());

operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/readcacheafterwrite/ownsecondaryupdate/OwnSecondaryUpdateReconciler.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
import io.javaoperatorsdk.operator.api.reconciler.ControllerConfiguration;
2828
import io.javaoperatorsdk.operator.api.reconciler.EventSourceContext;
2929
import io.javaoperatorsdk.operator.api.reconciler.Reconciler;
30+
import io.javaoperatorsdk.operator.api.reconciler.ResourceOperations;
3031
import io.javaoperatorsdk.operator.api.reconciler.UpdateControl;
3132
import io.javaoperatorsdk.operator.processing.event.source.EventSource;
3233
import io.javaoperatorsdk.operator.processing.event.source.informer.InformerEventSource;
@@ -50,7 +51,10 @@ public UpdateControl<OwnSecondaryUpdateCustomResource> reconcile(
5051
// version actually advances. With the read-cache-after-write filter in place, none of the
5152
// resulting watch events should trigger a fresh reconciliation.
5253
for (int i = 1; i <= OWN_SSA_COUNT; i++) {
53-
context.resourceOperations().serverSideApply(prepareCM(resource, i), configMapEventSource);
54+
context
55+
.resourceOperations()
56+
.serverSideApply(
57+
prepareCM(resource, i), configMapEventSource, new ResourceOperations.Options(true));
5458
}
5559
return UpdateControl.noUpdate();
5660
}

0 commit comments

Comments
 (0)