Upgrades for 1.0.0-SNAPSHOT

[holgerfriedrich]

Version 1.0.0-SNAPSHOT has been created. It lifts the minimum Java version from 11 to 21.

Along with that, we should check the following possible dependency upgrades:

(not yet evaluated)

as of now: NONE

Evaluated and dropped:

[INFO]   org.eclipse.jdt:ecj ......................................................................... 3.43.0 -> 3.44.0 (known issues)
[INFO]   org.jsoup:jsoup ............................................................................. 1.19.1 -> 1.21.2 (transitive dep of maven-plugin-tools-generators 3.15.2 (latest non-milestone rel))

PRs:

[INFO]   com.diffplug.spotless:spotless-maven-plugin ............................................... 2.46.1 -> 3.1.0
[INFO]   ${spotless.version} ......................................................................... 2.46.1 -> 3.1.0
[INFO]   com.puppycrawl.tools:checkstyle ............................................................ 10.26.1 -> 12.3.0
[INFO]   net.sourceforge.pmd:pmd-java ................................................................ 7.18.0 -> 7.19.0
[INFO]   net.sourceforge.pmd:pmd-test ................................................................ 7.18.0 -> 7.19.0
[INFO]   net.sourceforge.pmd:pmd-xml ................................................................. 7.18.0 -> 7.19.0
[INFO]   org.hamcrest:hamcrest-library ..................................................................... 2.2 -> 3.0
[INFO]   ${junit.version} ............................................................................ 5.11.4 -> 6.0.1
[INFO]   ${mockito.version} ......................................................................... 4.10.0 -> 5.21.0
[INFO]   ch.qos.logback:logback-classic .............................................................. 1.2.13 -> 1.5.23
[INFO]   javax.xml.bind:jaxb-api .......................................................... 2.3.1 -> 2.4.0-b180830.0359
[INFO]   org.eclipse.jdt:org.eclipse.jdt.annotation ................................................ 2.3.100 -> 2.4.100
[INFO]   org.glassfish.jaxb:jaxb-runtime ............................................................... 2.3.1 -> 4.0.6
[INFO]   org.junit.jupiter:junit-jupiter-api .......................................................... 5.11.4 -> 6.0.1
[INFO]   org.junit.jupiter:junit-jupiter-params ....................................................... 5.11.4 -> 6.0.1
[INFO]   org.mockito:mockito-core .................................................................... 4.10.0 -> 5.21.0
[INFO]   org.mockito:mockito-junit-jupiter ........................................................... 4.10.0 -> 5.21.0
[INFO]   org.slf4j:slf4j-api ......................................................................... 1.7.36 -> 2.0.17

[lsiepel]

The spotless plugin is also listed seperate can be consolidated by ${spotless.version}.

Not very into this repository, but as it does not depend on karaf 4.4.9 :-) we can update freely without having to bother that
slf4j and logback-classic cannot be upgrade due to pax dependency and jaxb / jakarta

As you tagged me, is there anything specific i can do here ?

[holgerfriedrich]

• Upgrade checkstyle to 12.3.0 #494
• Bump com.diffplug.spotless:spotless-maven-plugin from 2.46.1 to 3.1.0 #537
• Upgrade hamcrest to 3.0 #538
• Upgrade PMD to 7.19.0 #539
• Upgrade JUnit to 6.0.1 and Mockito to 5.21.0 #540
• Upgrade slf4j and logback #541
• Migrate javax.xml.bind to jakarta.xml.bind #542

[holgerfriedrich]

@lsiepel If all the PRs above get merged, the library upgrades are completed.
I will do a core build to see if the amount of warnings roughly stays the same.

What is likely missing for an 1.0 release, is to revisit the documentation of the corresponding tools and check for new rules introduced in the last years. The rulesets have not been adapted much since the early versions of SAT. In the meantime, the tools have improved and provide new rules, likely not incorporated into by our rulesets.

[holgerfriedrich]

Still LGTM with all patches:

I have sometimes seen some of the warning messages during build being interleaved (race condition during printing). I am sure I have seen this before, but I can't remember which version of SAT / tools were in use.

[holgerfriedrich]

Jenkins can now build and deploy again (this was blocked for quite a while as Java 11 was no longer supported).
I changed the setting to Java 21, and it deployed 1.0.0-SNAPSHOT to artifactory (snapshots).
https://ci.openhab.org/job/static-code-analysis/148/

Downloaded from openhab-snapshot: https://openhab.jfrog.io/openhab/libs-snapshot/org/openhab/tools/sat/sat-extension/1.0.0-SNAPSHOT/maven-metadata.xml (1.2 kB at 1.2 kB/s)
Downloading from openhab-snapshot: https://openhab.jfrog.io/openhab/libs-snapshot/org/openhab/tools/sat/sat-extension/1.0.0-SNAPSHOT/sat-extension-1.0.0-20251230.184643-1.pom