-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Issue #3930 add a dynamic html title #3980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
patricksimonian
wants to merge
7
commits into
openfrontio:main
Choose a base branch
from
patricksimonian:feature/dynamic-html-title
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+75
−0
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
f40305f
Issue #3930 add a dynamic html title
patricksimonian 3538dd1
Add code rabbit feedback for lobby timer
patricksimonian ec7ec1c
Update src/client/Main.ts
patricksimonian 6fb25a2
fix linting
patricksimonian cfe082c
Merge branch 'main' into feature/dynamic-html-title
patricksimonian 75bfbe8
Merge branch 'main' into feature/dynamic-html-title
patricksimonian 35c2c10
Merge branch 'main' into feature/dynamic-html-title
patricksimonian File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| /** | ||
| * Directly sets the document title. | ||
| * The caller is responsible for string concatenation and localization if needed. | ||
| */ | ||
| export function setTitle(title: string): void { | ||
| document.title = title; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| import { beforeEach, describe, expect, it } from "vitest"; | ||
| import { setTitle } from "../../src/client/PageTitleManager"; | ||
|
|
||
| describe("PageTitleManager", () => { | ||
| beforeEach(() => { | ||
| document.title = ""; | ||
| }); | ||
|
|
||
| it("should set a custom title", () => { | ||
| setTitle("Custom Title"); | ||
| expect(document.title).toBe("Custom Title"); | ||
| }); | ||
| }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.