Conversation
Plugin changes whose config failed validation (e.g. an Insert widget missing its priority) were still applied to the slot. The missing priority produced NaN in the ordering comparator, which Array.sort treats as equal, scrambling the order of every widget in the slot. validatePlugin now returns false for invalid configs and organizePlugins skips the change entirely: the misconfigured plugin is not rendered, operations targeting it become no-ops, and the logged error still indicates the misconfiguration. This also prevents invalid plugin operations from throwing a TypeError during validation.
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @cpruijsen! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Submit a signed contributor agreement (CLA)
If you've signed an agreement in the past, you may need to re-sign. Once you've signed the CLA, please allow 1 business day for it to be processed. 🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
2 participants
A plugin config missing
prioritystill renders, but every plugin in the slot loses its configuredorder. One incomplete entry silently reorders the whole slot, and the app looks wrong rather than
reporting anything.
validatePlugininsrc/plugins/data/utils.jsxlogged an error for a missingopand then carried onreturning a truthy value, so an invalid config was reported and kept. It now returns false for a
config whose
opis not one ofPLUGIN_OPERATIONS, so the entry is dropped rather than sorted with anundefined priority.
The operation check is against the actual set of valid operations rather than a truthiness test, since
an
opthat is present but not a real operation has the same effect as a missing one.The docstring said the function throws; it logs and returns, which is what callers depend on, so it now
says that.
Tests cover a missing
op, an invalid one, and that a valid slot still orders by priority.Fixes #68