From 1a02e1b39c96c05cc01c5455e272c43903e58c24 Mon Sep 17 00:00:00 2001 From: Andreas Stefl Date: Sun, 9 Aug 2026 13:49:04 +0200 Subject: [PATCH] test(html): render csv and zip in the output tests MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Both were skipped with a `TODO enable` next to them. Csv was skipped because it rendered as a line list, which was not worth pinning; it renders as a table now, so the skip has outlived its reason. Zip was skipped because there was no zip to render — the suite walks the input directory, and the public set had none. So the reference output gains what the two paths actually emit: `document.html` and `sheet0.html` for the csv, the one-sheet spreadsheet the generic renderer walks, and `files.html` for the zip. `zip/small.zip` is new input, and deliberately tiny — 271 bytes, two text files. An archive renders as a file listing with every entry inlined as a `data:application/octet-stream;base64` url, so a real-world archive would carry its whole content into the reference output. At this size the listing is 854 bytes and reviewable in a diff, while exercising the same code. Json stays skipped: it has no renderer of its own yet. Co-Authored-By: Claude Opus 5 (1M context) Claude-Session: https://claude.ai/code/session_01Nk1S12YmjBsmksSJ4tVB3X --- test/data.cmake | 4 ++-- test/src/html_output_test.cpp | 6 ++---- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/test/data.cmake b/test/data.cmake index 269673cd7..6447624b9 100644 --- a/test/data.cmake +++ b/test/data.cmake @@ -7,7 +7,7 @@ odr_test_data( PATH "input/odr-public" URL "https://github.com/opendocument-app/OpenDocument.test.git" - REVISION "42694a9ab07659ac1f9b937670385b6bc287455b") + REVISION "d7c093dffc987e8e5cf093ea7412371ce9d7363d") odr_test_data( PATH "input/odr-private" @@ -17,7 +17,7 @@ odr_test_data( odr_test_data( PATH "reference-output/odr-public" URL "https://github.com/opendocument-app/OpenDocument.test.output.git" - REVISION "2da5f0a3a246a0e0bc79fcee4c2f52afbc189fc4") + REVISION "e9aa12feb1601896f38ecbd04d7d84c31d805d26") odr_test_data( PATH "reference-output/odr-private" diff --git a/test/src/html_output_test.cpp b/test/src/html_output_test.cpp index 5859de7fe..0411ef2fc 100644 --- a/test/src/html_output_test.cpp +++ b/test/src/html_output_test.cpp @@ -112,10 +112,8 @@ TEST_P(HtmlOutputTests, html_meta) { EXPECT_EQ(test_file.type, file.file_type()); } - // TODO enable zip, csv, json - if (test_file.type == FileType::zip || - test_file.type == FileType::comma_separated_values || - test_file.type == FileType::javascript_object_notation) { + // TODO enable json + if (test_file.type == FileType::javascript_object_notation) { GTEST_SKIP(); }