From c1c18fca81b62c142e15f010344c10cebb289d83 Mon Sep 17 00:00:00 2001
From: Claude <noreply@anthropic.com>
Date: Sat, 18 Jul 2026 14:08:40 +0000
Subject: [PATCH] refactor(app-shell): drop agent `visibility` from
 AgentPreview (#1901)

The agent `visibility` field was removed from the spec as an unenforced
security property (framework #1901, ADR-0056 D8). AgentPreview rendered it as a
persona-header pill, which now always fell back to the hardcoded default and
implied a gating dial that does not exist.

Remove the `visibility` read and its pill from the persona header. The `Lock`
icon import stays (still used by the Permissions rail block).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012gckUwoUMWvTWfGHFgWAob
---
 .../src/views/metadata-admin/previews/AgentPreview.tsx        | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/packages/app-shell/src/views/metadata-admin/previews/AgentPreview.tsx b/packages/app-shell/src/views/metadata-admin/previews/AgentPreview.tsx
index 4b4e1a2ba..e9d915a23 100644
--- a/packages/app-shell/src/views/metadata-admin/previews/AgentPreview.tsx
+++ b/packages/app-shell/src/views/metadata-admin/previews/AgentPreview.tsx
@@ -5,7 +5,7 @@
  *
  * Shows the configuration an operator needs to sanity-check an agent
  * before saving:
- *   • Persona header (avatar, label, role, visibility, active flag).
+ *   • Persona header (avatar, label, role, active flag).
  *   • Model config (provider, model id, temperature, max tokens).
  *   • System prompt / instructions in a scrollable monospace block.
  *   • Skills + Tools as two collapsible chip lists.
@@ -62,7 +62,6 @@ export function AgentPreview({ name, draft }: MetadataPreviewProps) {
   const avatar = (d.avatar as string | undefined) || undefined;
   const instructions = String(d.instructions ?? '');
   const active = d.active !== false;
-  const visibility = String(d.visibility ?? 'organization');
   const model = (d.model ?? {}) as ModelConfig;
   const skills: string[] = Array.isArray(d.skills) ? (d.skills as string[]) : [];
   const tools: ToolRef[] = Array.isArray(d.tools) ? (d.tools as ToolRef[]) : [];
@@ -120,7 +119,6 @@ export function AgentPreview({ name, draft }: MetadataPreviewProps) {
                 {role && <div className="text-xs text-muted-foreground mt-0.5">{role}</div>}
                 <div className="mt-1.5 flex flex-wrap items-center gap-x-3 gap-y-1 text-[11px]">
                   <Pill icon={active ? Eye : EyeOff} label={active ? 'Active' : 'Disabled'} tone={active ? 'green' : 'gray'} />
-                  <Pill icon={Lock} label={visibility} />
                   {model.provider && <Pill icon={Sparkles} label={`${model.provider}${model.model ? ` · ${model.model}` : ''}`} mono />}
                   {model.temperature != null && <Pill icon={Gauge} label={`temp ${model.temperature}`} />}
                   {model.maxTokens != null && <Pill label={`max ${model.maxTokens}t`} />}