From e9342a87e0196848c133c501bba0e8ec3544817d Mon Sep 17 00:00:00 2001 From: Claude Date: Mon, 20 Jul 2026 01:35:25 +0000 Subject: [PATCH] =?UTF-8?q?ci:=20drop=20the=20OS=5FSANDBOX=5FHOOK=5FTIMEOU?= =?UTF-8?q?T=5FMS=3D10000=20floor=20=E2=80=94=20redundant=20after=20ADR-01?= =?UTF-8?q?02=20D1?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit #3270 raised the sandbox hook budget workflow-wide to paper over the #3259 load flake: on an oversubscribed runner the fixed per-invocation WASM-creation cost alone tripped the 250ms *wall-clock* hook deadline. ADR-0102 D1 (#3301) changed the budget to *script CPU-time* — VM creation and idle host-await time are no longer charged — so the 250ms default is meaningful again on a loaded runner and this global floor is no longer needed. Removing it also validates the fix end-to-end: the sandbox suite (incl. the nested-write integration tests, which run at the stock default) must stay green at 250ms on CI. Tests that assert a specific budget set it explicitly and are unaffected; production always kept 250ms/5000ms. The env override remains available for constrained hardware. Co-Authored-By: Claude Opus 4.8 Claude-Session: https://claude.ai/code/session_011iJLjqToxNv1aYP3syQtRp --- .github/workflows/ci.yml | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index db55d04ad7..6d67487569 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -15,17 +15,6 @@ concurrency: group: ci-${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }} cancel-in-progress: true -# The QuickJS sandbox compiles a fresh WASM module per hook/action invocation -# (and a nested hook compiles another inside the parent's budget). Hosted runners -# are 4-vCPU and the test job oversubscribes them (`turbo --concurrency=4` + each -# vitest worker), so that fixed VM-creation cost alone intermittently tripped the -# 250ms hook default even while the VM was progressing — a load flake unrelated to -# the change under test (#3259). Raise the sandbox hook budget for the whole -# workflow; production keeps the 250ms default (this only sets it in CI). Real -# hangs are still bounded by each test's own vitest timeout. -env: - OS_SANDBOX_HOOK_TIMEOUT_MS: '10000' - jobs: filter: runs-on: ubuntu-latest