From 1242020b07ab0079d9484991cb620d10b18b90ff Mon Sep 17 00:00:00 2001 From: Jack Zhuang <277994282+os-zhuang@users.noreply.github.com> Date: Fri, 17 Jul 2026 20:07:37 +0800 Subject: [PATCH] docs(create-objectstack): correct a bogus issue reference in the pnpm-build-approvals comments MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit #3119 cited "#3110" in four comments as the pnpm 11 build-approvals bug. #3110 is an unrelated, already-closed issue — "ObjectLogger file destination silently no-ops in ESM builds" (fixed by #3116). The reference was fabricated: the pnpm 11 scaffold breakage was found while diagnosing the red Publish Smoke gate and has no issue of its own, so the correct citation is the PR that fixed it, #3119. Comment-only. Left a wrong pointer in the two places most likely to be read by whoever next touches this: the "why is the smoke's pnpm unpinned" rationale in the script header, and the ratchet that guards the template. Co-Authored-By: Claude Opus 4.8 --- packages/create-objectstack/src/template-consistency.test.ts | 4 ++-- scripts/publish-smoke.sh | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/create-objectstack/src/template-consistency.test.ts b/packages/create-objectstack/src/template-consistency.test.ts index 8ff0946580..2d1de5c150 100644 --- a/packages/create-objectstack/src/template-consistency.test.ts +++ b/packages/create-objectstack/src/template-consistency.test.ts @@ -74,10 +74,10 @@ describe('blank template manifest engines.protocol (ADR-0087 D1)', () => { // pnpm 11 turned an unapproved dependency build script from a warning into a // hard error, so the template declaring nothing meant `npx create-objectstack` -// + `pnpm install` exited 1 for every user on a current pnpm (#3110). Both keys +// + `pnpm install` exited 1 for every user on a current pnpm (#3119). Both keys // are load-bearing and read by different pnpm versions: pnpm 11 honours only // `allowBuilds`, while pnpm 10.0–10.30 understand only `onlyBuiltDependencies`. -describe('blank template pnpm build approvals (#3110)', () => { +describe('blank template pnpm build approvals (#3119)', () => { const wsPath = path.join(pkgRoot, 'src', 'templates', 'blank', 'pnpm-workspace.yaml'); const APPROVED = ['better-sqlite3', 'esbuild']; // Strip comments: the prose below explains these keys and must not satisfy diff --git a/scripts/publish-smoke.sh b/scripts/publish-smoke.sh index ca61542b42..41b4fa6409 100644 --- a/scripts/publish-smoke.sh +++ b/scripts/publish-smoke.sh @@ -48,7 +48,7 @@ # create-objectstack template needs updating. It has already happened once: # pnpm 11 turned unapproved build scripts from a warning into a hard error, so # every `npx create-objectstack` + `pnpm install` exited 1 until the template -# started declaring `allowBuilds` (#3110). +# started declaring `allowBuilds` (#3119). # # Usage: # bash scripts/publish-smoke.sh @@ -129,7 +129,7 @@ if [ "$SMOKE_MODE" = "pack" ]; then # Appending, not overwriting, is load-bearing: the template's build-approval # block (allowBuilds / onlyBuiltDependencies) is part of what a user gets, so # it has to be part of what this gate tests. This script used to hand-write - # the whole file, declaring the approvals itself — which is exactly how #3110 + # the whole file, declaring the approvals itself — which is exactly how #3119 # stayed invisible here: a locally-authored declaration proves nothing about # what the template ships. #