You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
feat(spec)!: the six validation variants each close against their own key set (#4001)
`validation` was the registered metadata type this campaign kept deferring: a
`z.lazy()` discriminated union whose six variants each `.extend()` a shared
base, so the one-call `strictObject` conversion the other types took does not
apply to it.
WHY NOT JUST CLOSE THE BASE. `.extend()` inherits strictness, so closing
`BaseValidationSchema` alone would have rejected unknown keys correctly. But an
error map closes over the key list it was BUILT with, and for the base that is
only the shared keys — so a typo of a variant's own key (`transtions` for
`transitions`, `jsonschema` for `schema`) would have been rejected with no
rename offered. That is the difference between a fixable error and a confusing
one, and it is the whole reason the campaign insists rejections carry the fix.
The union discriminates on `type`, so an author is always on exactly one
variant and that variant's FULL key set is the right candidate list. The base is
now a named shape spread into six `strictObject` calls, each with the aliases
that fit its own vocabulary. No `BaseValidationSchema` object remains — nothing
ever parsed the base alone.
THE ENVELOPE. `validation` is registered, so the loader stamps `_packageId` /
`_provenance` on it and `getMetaItemLayered` → `saveMetaItem` round-trips a body
carrying them — and the schema could not represent them, so they were dropped on
every parse. Declared once in the shared shape, inherited by all six. The type
comes off the debt list in `kernel/metadata-type-schemas.test.ts`, which carries
a reverse pin, so removing the entry was forced rather than optional. Five
remain: action, field, mapping, page, translation.
AND THE GATE LEARNED THE IDIOM AGAIN. Its strictness-claim check matched only a
literal `.strict()`, so a file converted to `strictObject` read as NOT strict and
the gate called a true claim a lie. Same blind spot the site count had one batch
ago, for the same reason: a measuring tool has to learn the idiom whenever the
idiom changes. Both now accept either spelling.
Authoring impact: a key none of the variants declares is rejected instead of
silently discarded — it was already being ignored, so no working behavior
changes. The rejection names which variant it landed on ("this state-machine
validation rule"), echoes the key, and suggests from that variant's own set.
Verified: spec 283 files / 7159 tests, `tsc --noEmit` clean, all 8 generated
artifacts current (the only regeneration is the six variants' envelope tables),
all 15 `check:*` gates green. Probed directly: valid rule parses, unknown key
rejected, a variant-specific typo gets its rename, envelope accepted.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WnqGjQFQMqd5k81LYV8SCY
The six `validation` rule variants reject unknown keys, each against its own key set, and the type can finally represent its ADR-0010 protection envelope.
6
+
7
+
`validation` was the registered metadata type this campaign kept deferring: a `z.lazy()` discriminated union whose six variants each `.extend()` a shared base, so the one-call `strictObject` conversion the other types took does not apply.
8
+
9
+
**Why not just close the base.**`.extend()` inherits strictness, so closing `BaseValidationSchema` alone would have rejected unknown keys correctly — but the error map closes over the key list it was *built* with, which for the base is only the shared keys. A typo of a variant's own key (`transtions` for `transitions`, `formuIa` for `formula`) would have been rejected with no rename offered, which is the difference between a fixable error and a confusing one. The union discriminates on `type`, so an author is always on exactly one variant and that variant's full key set is the right candidate list. The base is now a named shape spread into six `strictObject` calls, each with the aliases that fit its own vocabulary.
10
+
11
+
**The envelope.**`validation` is a registered metadata type, so `MetadataPlugin`'s loader stamps `_packageId` / `_provenance` on it and `getMetaItemLayered` → `saveMetaItem` round-trips a body carrying them — and the schema could not represent them, so they were dropped on every parse. Declared once in the shared shape, so all six variants inherit it, and the type comes off the debt list in `kernel/metadata-type-schemas.test.ts` (that list carries a reverse pin, so removing an entry is forced rather than optional).
12
+
13
+
Authoring impact: a key none of the variants declares is now rejected instead of silently discarded — it was already being ignored, so no working behavior changes. The rejection names which variant it landed on ("this state-machine validation rule"), echoes the key, and suggests the closest declared one from that variant's full set.
|**fields**|`string[]`| ✅ | Fields involved. Only fields[0] is read (labels which field the violation attaches to); the rest are advisory. Shares script’s evaluation path. |
@@ -191,6 +205,13 @@ const result = ConditionalValidation.parse(data);
|**fields**|`string[]`| ✅ | Fields involved. Only fields[0] is read (labels which field the violation attaches to); the rest are advisory. Shares script’s evaluation path. |
@@ -381,6 +451,13 @@ This schema accepts one of the following structures:
@@ -262,7 +262,8 @@ tightening (the #4001 "sharing-rule lesson": candidates, not verdicts).
262
262
|`hook.zod.ts` / `hook-body.zod.ts`| 6+2 | mixed |**strict as of #4001 data step** for the AUTHORING shapes: `HookSchema` (+ `retryPolicy`) and both body branches (`ExpressionBodySchema` / `ScriptBodySchema`). `HookContextSchema` and its `session` / `provenance` / `user` blocks are the RUNTIME shape the engine hands a handler — they stay tolerant, and must: strictness there would make an engine-internal enrichment (as `provenance` was in #3712) a breaking change for anyone parsing a context they were given. The file's old blanket `authorable (p)` was too wide — verification split it |
|`validation.zod.ts`| 6 | authorable |**strict as of #4001 batch 3b** — a `z.lazy()` discriminated union, so the one-call conversion does not apply: each of the six variants builds its own `strictObject` from a shared `BASE_VALIDATION_SHAPE`. Closing the base alone would have rejected correctly but suggested from the SHARED keys only, so a typo of a variant's own key (`transtions` → `transitions`) would get no rename. Site count 1 → 6 because the six variants are now object sites in their own right. The ADR-0010 envelope lives in the shared shape, so all six inherit it |
0 commit comments