fix(cloud-connection,metadata): the canonical-first read needs a per-name try -- getService throws on an empty slot (#4251)

CI caught the shape my local run could not (I built cloud-connection but ran
only metadata's tests -- cloud-connection's own suites mock a kernel that
registers ONLY the alias): `getService` THROWS for an unregistered slot, so

    try { a = getService('http.server') ?? getService('http-server'); } catch {...}

never reaches the alias -- the first name's throw exits the whole try. Split
into a per-name try (readServer helper) in all four readers.

Worth recording: the pre-existing alias-first read in metadata/plugin.ts had
the SAME shape, so its `?? getService('http.server')` fallback never once
fired either -- a decorative fallback, the declared-vs-actual gap this work
line keeps finding, now actually implemented in both directions.

Verified serially (the earlier 6-file FAIL was local vitest concurrency noise
while spec's dts build ran in parallel -- single-file and serial reruns green):
cloud-connection 64/12, metadata 281/13, both dts builds, eslint clean.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

Author: os-zhuang

packages/cloud-connection/src/marketplace-install-local-plugin.ts

@@ -121,16 +121,20 @@ export class MarketplaceInstallLocalPlugin implements Plugin {
             await this.rehydrate(ctx);
 
             // 2. Mount HTTP endpoints.
-            // [#4251] Canonical name first — see marketplace-proxy-plugin.
-            let httpServer: IHttpServer | undefined;
-            try {
-                httpServer = ctx.getService<IHttpServer>('http.server')
-                    ?? ctx.getService<IHttpServer>('http-server');
-            } catch {
+            // [#4251] Read canonical-first with a REAL per-name fallback:
+            // `getService` THROWS for an empty slot, so a single try around
+            // `canonical ?? alias` never reaches the alias — the shape the old
+            // alias-first read had too, meaning its fallback never once fired.
+            const readServer = (name: string): IHttpServer | undefined => {
+                try { return ctx.getService<IHttpServer>(name); } catch { return undefined; }
+            };
+            // Canonical first — see marketplace-proxy-plugin.
+            const httpServer = readServer('http.server') ?? readServer('http-server');
+            if (!httpServer) {
                 ctx.logger?.warn?.('[MarketplaceInstallLocal] http-server not available — install endpoints not mounted');
                 return;
             }
-            if (!httpServer || typeof httpServer.getRawApp !== 'function') {
+            if (typeof httpServer.getRawApp !== 'function') {
                 ctx.logger?.warn?.('[MarketplaceInstallLocal] http-server missing getRawApp() — install endpoints not mounted');
                 return;
             }

packages/cloud-connection/src/marketplace-proxy-plugin.ts

@@ -183,19 +183,21 @@ export class MarketplaceProxyPlugin implements Plugin {
                 manifest?.register?.(MARKETPLACE_BROWSE_UI_BUNDLE);
             } catch { /* no manifest service */ }
 
-            // [#4251] `http.server` is the canonical name (the only one every
-            // provider registers — runtime's `config.server` path registers no
-            // alias, which made this alias-only read an empty-slot miss there).
-            // The alias fallback dies with the alias registrations.
-            let httpServer: IHttpServer | undefined;
-            try {
-                httpServer = ctx.getService<IHttpServer>('http.server')
-                    ?? ctx.getService<IHttpServer>('http-server');
-            } catch {
+            // [#4251] Read canonical-first with a REAL per-name fallback:
+            // `getService` THROWS for an empty slot, so a single try around
+            // `canonical ?? alias` never reaches the alias — the shape the old
+            // alias-first read had too, meaning its fallback never once fired.
+            const readServer = (name: string): IHttpServer | undefined => {
+                try { return ctx.getService<IHttpServer>(name); } catch { return undefined; }
+            };
+            // `http.server` is canonical (the only name every provider
+            // registers); the alias fallback dies with the alias registrations.
+            const httpServer = readServer('http.server') ?? readServer('http-server');
+            if (!httpServer) {
                 ctx.logger?.warn?.('[MarketplaceProxyPlugin] http-server not available — marketplace routes not mounted');
                 return;
             }
-            if (!httpServer || typeof httpServer.getRawApp !== 'function') {
+            if (typeof httpServer.getRawApp !== 'function') {
                 ctx.logger?.warn?.('[MarketplaceProxyPlugin] http-server missing getRawApp() — marketplace routes not mounted');
                 return;
             }

packages/cloud-connection/src/runtime-config-plugin.ts

@@ -183,17 +183,20 @@ export class RuntimeConfigPlugin implements Plugin {
 
     start = async (ctx: PluginContext): Promise<void> => {
         ctx.hook('kernel:ready', async () => {
-            // [#4251] Canonical name first — see marketplace-proxy-plugin for
-            // the alias-only-miss this fixes; the fallback dies with the alias.
-            let httpServer: IHttpServer | undefined;
-            try {
-                httpServer = ctx.getService<IHttpServer>('http.server')
-                    ?? ctx.getService<IHttpServer>('http-server');
-            } catch {
+            // [#4251] Read canonical-first with a REAL per-name fallback:
+            // `getService` THROWS for an empty slot, so a single try around
+            // `canonical ?? alias` never reaches the alias — the shape the old
+            // alias-first read had too, meaning its fallback never once fired.
+            const readServer = (name: string): IHttpServer | undefined => {
+                try { return ctx.getService<IHttpServer>(name); } catch { return undefined; }
+            };
+            // Canonical first — see marketplace-proxy-plugin.
+            const httpServer = readServer('http.server') ?? readServer('http-server');
+            if (!httpServer) {
                 ctx.logger?.warn?.('[RuntimeConfigPlugin] http-server not available — runtime/config not mounted');
                 return;
             }
-            if (!httpServer || typeof httpServer.getRawApp !== 'function') {
+            if (typeof httpServer.getRawApp !== 'function') {
                 ctx.logger?.warn?.('[RuntimeConfigPlugin] http-server missing getRawApp() — runtime/config not mounted');
                 return;
             }

packages/metadata/src/plugin.ts

@@ -409,11 +409,17 @@ export class MetadataPlugin implements Plugin {
         try {
             // [#4251] Both names are the SAME instance; `http.server` is the
             // canonical one (the only name every provider registers), read
-            // first. `getRawApp?()` is on the contract now — the deliberate
-            // framework-handle escape, declared once there instead of per
-            // consumer. The alias fallback dies with the alias registrations.
-            const httpServer = ctx.getService<IHttpServer>('http.server')
-                ?? ctx.getService<IHttpServer>('http-server');
+            // first. Per-name try — `getService` THROWS for an empty slot, so
+            // a single try around `canonical ?? alias` never reaches the
+            // alias: exactly the shape this read had before (alias-first),
+            // whose fallback therefore never once fired. `getRawApp?()` is on
+            // the contract now — the deliberate framework-handle escape,
+            // declared once there instead of per consumer. The alias fallback
+            // dies with the alias registrations.
+            const readServer = (name: string): IHttpServer | undefined => {
+                try { return ctx.getService<IHttpServer>(name); } catch { return undefined; }
+            };
+            const httpServer = readServer('http.server') ?? readServer('http-server');
             if (httpServer && typeof httpServer.getRawApp === 'function') {
                 const { registerMetadataHmrRoutes } = await import('./routes/hmr-routes.js');
                 const hub = registerMetadataHmrRoutes(httpServer.getRawApp(), this.manager);