Commit 2be906e
committed
test(drivers): 剥掉 33 处已死的
`SqlDriver.create/find/update/delete` 声明的是 `options?: DriverOptions`,
`bypassTenantAudit` 是 `DriverOptionsSchema` 上的合法键(spec 17.0.0 起,
#4311),所以这些 `as any` 早就不需要了。它们不是无害的:转型关掉的是**整个
选项对象**的检查,于是这些站点上任何键名拼错都不报错。
`TursoDriver` 一并纳入:PR #6755(#6402)已把 17 个 override 的
`options?: any` 全部收窄成 `options?: DriverOptions`,turso 当初被单独拆出去
的唯一理由已经消失;#6394 也已落地,`as never` 残留为零。留着这 4 处就没有
第二个人来收。
逐包实测(依赖闭包先构建,避免读到过期的 `dist/*.d.ts`):
| 包 | 剥掉 | 文件 |
|---|---:|---:|
| driver-sql | 11 | 6 |
| driver-sqlite-wasm | 19 | 8 |
| driver-turso | 4 | 2 |
其中 `sqlite-wasm-pagination-conformance.test.ts:34` 是单据的 grep 漏掉的第
19 处 —— 形状是 `as unknown as Parameters<SqliteWasmDriver['find']>[2]`。
两处具名 const(`sql-driver-limit-zero-presence.test.ts` 的 `READ`、
`sqlite-wasm-pagination-conformance.test.ts` 的 `READ_OPTIONS`)只删转型**不
足以**换回检查:超额属性检查只对直接位置上的新鲜字面量生效。实测确认,
`const READ = { tenantId: 't1', bypassTenantAuditt: true }` 在只删转型的情况下
EXIT=0、零报错 —— 拼错被静默吞掉。因此这两处改为 `: DriverOptions` 标注,让
字面量在声明处受检。
⛔ 未触碰 `packages/objectql/src/engine-unknown-option.test.ts` 的 2 处:那是
另一个包、另一种形状(转型套在传给 `engine.find(...)` 的查询对象上,不是
`DriverOptions` 参数),且 `bypassTenantAudit` 出现在该文件自己的 `PASSTHROUGH`
漂移钉里 —— 剥掉等于删掉被测对象。属 engine-core 车道。
纯测试改动,无 changeset。
Refs #6754, #6394, #6402, #6755
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MVa7roTgq6gGty2bG2KiEfbypassTenantAudit 选项转型,换回编译期检查 (#6754)1 parent 73bff86 commit 2be906e
16 files changed
Lines changed: 36 additions & 34 deletions
File tree
- packages/drivers
- driver-sqlite-wasm/src
- driver-sql/src
- driver-turso/src
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
61 | 61 | | |
62 | 62 | | |
63 | 63 | | |
64 | | - | |
| 64 | + | |
65 | 65 | | |
66 | 66 | | |
67 | 67 | | |
| |||
Lines changed: 2 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
61 | 61 | | |
62 | 62 | | |
63 | 63 | | |
| 64 | + | |
64 | 65 | | |
65 | 66 | | |
66 | 67 | | |
| |||
96 | 97 | | |
97 | 98 | | |
98 | 99 | | |
99 | | - | |
| 100 | + | |
100 | 101 | | |
101 | 102 | | |
102 | 103 | | |
| |||
Lines changed: 5 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
108 | 108 | | |
109 | 109 | | |
110 | 110 | | |
111 | | - | |
| 111 | + | |
112 | 112 | | |
113 | 113 | | |
114 | 114 | | |
| |||
118 | 118 | | |
119 | 119 | | |
120 | 120 | | |
121 | | - | |
| 121 | + | |
122 | 122 | | |
123 | 123 | | |
124 | 124 | | |
| |||
128 | 128 | | |
129 | 129 | | |
130 | 130 | | |
131 | | - | |
| 131 | + | |
132 | 132 | | |
133 | 133 | | |
134 | 134 | | |
| |||
217 | 217 | | |
218 | 218 | | |
219 | 219 | | |
220 | | - | |
| 220 | + | |
221 | 221 | | |
222 | 222 | | |
223 | 223 | | |
| |||
244 | 244 | | |
245 | 245 | | |
246 | 246 | | |
247 | | - | |
| 247 | + | |
248 | 248 | | |
249 | 249 | | |
250 | 250 | | |
| |||
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
193 | 193 | | |
194 | 194 | | |
195 | 195 | | |
196 | | - | |
| 196 | + | |
197 | 197 | | |
198 | 198 | | |
199 | 199 | | |
| |||
307 | 307 | | |
308 | 308 | | |
309 | 309 | | |
310 | | - | |
| 310 | + | |
311 | 311 | | |
312 | 312 | | |
313 | 313 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
143 | 143 | | |
144 | 144 | | |
145 | 145 | | |
146 | | - | |
| 146 | + | |
147 | 147 | | |
148 | 148 | | |
149 | 149 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
433 | 433 | | |
434 | 434 | | |
435 | 435 | | |
436 | | - | |
| 436 | + | |
437 | 437 | | |
438 | 438 | | |
439 | 439 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
70 | 70 | | |
71 | 71 | | |
72 | 72 | | |
73 | | - | |
| 73 | + | |
74 | 74 | | |
75 | 75 | | |
76 | 76 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
32 | | - | |
| 32 | + | |
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
332 | 332 | | |
333 | 333 | | |
334 | 334 | | |
335 | | - | |
| 335 | + | |
336 | 336 | | |
337 | 337 | | |
338 | 338 | | |
| |||
Lines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
35 | | - | |
36 | | - | |
| 35 | + | |
| 36 | + | |
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
| |||
44 | 44 | | |
45 | 45 | | |
46 | 46 | | |
47 | | - | |
| 47 | + | |
48 | 48 | | |
49 | 49 | | |
50 | 50 | | |
| |||
0 commit comments