Skip to content

Commit 15fbf81

Browse files
committed
fix(tooling): drop the wildcard ledger's entry for the mount #4112 removed
NOT part of this branch's work — `main` is red on it and every open PR fails the same check, so this unblocks rather than waits. `origin/main` @ 857a6cf fails `check:wildcard-fallthrough` on its own, verified in a detached worktree with no branch involved: ✗ packages/adapters/hono/src/index.ts:all `${prefix}/storage/*` DECLARED but not found by the scan. Semantic conflict between two commits that both landed, not a bug in the guard. #4112 retired that mount outright — the adapter now carries a comment where `app.all(prefix + '/storage/*')` was, because the handler spoke a storage contract that does not exist and the wildcard claimed the whole `/storage` subtree. #4116's MOUNTS ledger (#4122) was written against a tree that still had it and landed after the removal, so the entry was stale on arrival. Git merged both cleanly because they touch different lines; the guard is what noticed, which is it working on day one. Dropping the entry is the whole fix — there is nothing left to ratchet when the mount it names does not exist. Its `${prefix}/auth/*` sibling is untouched and still correctly ratcheted to #4117. After: 6 yielding / 1 ratcheted / 5 exempt (12 namespace-claiming mounts). Flagged on #4122 as well, so whoever owns it can take it back if they would rather land it themselves. Also enumerated the ESLint job properly this time — it runs ELEVEN checks, not the six I had been running (`doc-authoring`, `authz-resolver`, `release-notes` and `node-version` were the ones I was missing, plus `pnpm lint` itself). All eleven pass, and `pnpm lint` is clean once `.cache/` — the objectui console build artifact an earlier `.objectui-sha` bump left in this worktree — is removed. Those 61 "errors" were entirely that directory; CI checks out fresh and never had them. Full suite: 129/129 packages. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CYbS3kS8xzsHNXFTzp4e2z
1 parent 637bb32 commit 15fbf81

1 file changed

Lines changed: 6 additions & 3 deletions

File tree

scripts/check-wildcard-fallthrough.mjs

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -155,9 +155,12 @@ const MOUNTS = {
155155
'packages/adapters/hono/src/index.ts:all `${prefix}/auth/*`': {
156156
ratchet: '#4117 — terminal, same shape as #4088; adapter has no in-repo consumer',
157157
},
158-
'packages/adapters/hono/src/index.ts:all `${prefix}/storage/*`': {
159-
ratchet: '#4117 — terminal, same shape as #4088; adapter has no in-repo consumer',
160-
},
158+
// The `${prefix}/storage/*` sibling of the above is gone: #4112 retired that
159+
// mount outright (the handler spoke a storage contract that does not exist,
160+
// and the wildcard claimed the whole `/storage` subtree). #4116's ledger was
161+
// written against a tree that still had it and landed after the removal, so
162+
// this entry was stale on arrival and main went red on it. Nothing to ratchet
163+
// — the mount it named does not exist.
161164
};
162165

163166
/** HTTP-verb registrars plus `use`; anything that can claim a path pattern. */

0 commit comments

Comments
 (0)