Skip to content

Commit 1561479

Browse files
baozhoutaoclaude
andauthored
test(objectql): drop the dangling debug helper in save-meta-response-conformance (#6431)
The `LOG` helper declared at :119 referenced two names that exist nowhere in the file: `appendFileSync` (never imported from `node:fs`) and `OUT` (never defined). `LOG` itself was never called, so it never threw at runtime — it was dead debug scaffolding left behind when its import and constant were dropped. A debug helper that looks usable but raises `ReferenceError` the moment someone uncomments a call is worse than no helper at all. Also passes the required `packageId` argument to `registry.registerObject` at :115, which was called with one argument against a `(schema, packageId, ...)` signature. Both defects are invisible to every gate because `packages/objectql/tsconfig.json` excludes `**/*.test.ts` (#4311), so `tsc` never reads this file; vitest does not type-check and ESLint does no cross-symbol resolution. Fixes #5924 Claude-Session: https://claude.ai/code/session_019Q7oc7ASjh8yxyS3Yz78We Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
1 parent 2a0d65e commit 1561479

1 file changed

Lines changed: 1 addition & 3 deletions

File tree

packages/objectql/src/save-meta-response-conformance.test.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -112,12 +112,10 @@ async function makeProtocol() {
112112
const { driver } = makeMemoryDriver();
113113
engine.registerDriver(driver, true);
114114
await engine.init();
115-
engine.registry.registerObject(sysMetadataObject as any);
115+
engine.registry.registerObject(sysMetadataObject as any, 'test-package');
116116
return new ObjectStackProtocolImplementation(engine);
117117
}
118118

119-
const LOG = (...a: any[]) => appendFileSync(OUT, a.join(' ') + '\n');
120-
121119
const viewBody = (label: string) => ({ name: 'cases', type: 'grid', label, columns: ['id'] });
122120

123121
/** Keys the producer emitted that the schema refused to carry through. */

0 commit comments

Comments
 (0)