Respect vim.o.shell

[adigitoleo]

Currently, this plugin always uses vim.env.SHELL as the default command. This behaviour is inconsistent with :terminal, which uses vim.o.shell. Using the latter value allows for more flexibility, since users can set the shell that they want neovim to use independently of the $SHELL used outside of nvim.

For example, on a shared system, I have $SHELL set to /bin/bash, but prefer to use $HOME/.local/bin/zsh for vim.o.shell.

Would it be reasonable to switch to using vim.o.shell by default?

[Vinni-Cedraz]

if I could at least make the default shell work I'd be happy. Currently it opens a window without anything not even a shell

[adigitoleo]

@Vinni-Cedraz If you are on NeoVim, I have since created my own plugin to handle floating terminals: haunt.nvim. It won't help for vim8 though, as it is written in lua.

[adigitoleo]

I have pushed a v2 of haunt.nvim which fixes a lot of things. But requires neovim 0.10. Will write a quick blog post about it with a video demo soon, and push a patch to try to restore support for 0.9.

[russell-knight]

On Windows when I set vim.o.shell = "pwsh.exe" in my config, FTerm stops working. When I open FTerm I'm presented with a blank window. If I then press enter the following error appears:

This is my FTerm config

{
  "numToStr/FTerm.nvim",
  config = function()
    require("FTerm").setup({
      cmd = 'pwsh.exe',
      border     = 'double',
      dimensions = {
        height = 0.9,
        width = 0.9,
      },
    })
    vim.keymap.set('n', '<A-i>', '<CMD>lua require("FTerm").toggle()<CR>')
    vim.keymap.set('t', '<A-i>', '<C-\\><C-n><CMD>lua require("FTerm").toggle()<CR>')
  end
}

As mentioned above :terminal uses vim.o.shell. I've changed my config so that this command will use Powershell. I'm unsure why setting this is breaking FTerm though, especially because I have the cmd set in my config to 'pwsh.exe'

[adigitoleo]

@russell-knight Rather unhelpfully, the result of net helpmsg 4000 on powershell only says that

WINS encountered an error while processing the command.

You didn't mention if :terminal still works as expected. The last commit on this repo is 2 years old, would you care to try my haunt.nvim plugin, which will respect vim.o.shell = 'pwsh.exe' setting and for me on Windows 11 Home with Powershell 7.4.6 works fine (to test, with default setup, run :HauntTerm).

[russell-knight]

:terminal is behaving as expected. I'll see if I can find some time this to try our your plugin 🙂