test: cover Windows -- arg forwarding in shims#9400
Draft
Aniketiitk21 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Windows shim regression coverage for
npm test -- --foo=bar.Issue #9353 reproduces on the published
npm@11.14.1PowerShell-Commandpath, where--foo=baris misclassified as npm CLI config instead of being forwarded to the script after the first--.Current
mainalready forwards the argument correctly. This PR locks that behavior in with an explicit windows-shims test so the PowerShell path cannot regress.Test plan
npm@11.14.1mainforwards--foo=barcorrectly throughnpm.cmdmainforwards--foo=barcorrectly throughnpm.ps1test -- --foo=barcoverage totest/bin/windows-shims.jsRefs #9353.