doc: clarify filter option of sqlite.database.applyChangeset#63515
Open
aduh95 wants to merge 2 commits into
Open
doc: clarify filter option of sqlite.database.applyChangeset#63515aduh95 wants to merge 2 commits into
filter option of sqlite.database.applyChangeset#63515aduh95 wants to merge 2 commits into
Conversation
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Collaborator
|
Review requested:
|
cjihrig
approved these changes
May 23, 2026
Contributor
|
Maybe we should update to |
Contributor
Author
I have no opinion, but in any case we probably want to land the doc fix ASAP |
geeksilva97
approved these changes
May 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current version is quite confusing, if not plain wrong. I was heavily inspired by https://sqlite.org/session.html#sqlite3changeset_apply for that change.
For reference, our
xFilteris implemented innode/src/node_sqlite.cc
Lines 2238 to 2242 in 89c414a